Skip to content

deps: bump openzeppelin-contracts 4.8.3 -> 5.6.1#18

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-05-10-oz-5.6.1
May 9, 2026
Merged

deps: bump openzeppelin-contracts 4.8.3 -> 5.6.1#18
thedavidmeister merged 1 commit into
mainfrom
2026-05-10-oz-5.6.1

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

@thedavidmeister thedavidmeister commented May 9, 2026

Cascade-bump for the rain.math.float soldeer migration. The OZ Math.Rounding enum reorders between 4.x and 5.x, but our code constructs values via integer cast so the shift is a no-op for the unsigned cases this lib uses. forge t est passes 78/78.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Upgraded OpenZeppelin contracts dependency from version 4.8.3 to 5.6.1, including updates to fixed-point decimal arithmetic and string formatting utilities with corresponding test updates.

Review Change Stack

Aligns with rain.math.float migration. OZ Math.Rounding enum reordered
between 4.x and 5.x but tests construct values via integer cast so the
shift is a no-op for the unsigned cases this lib uses.

Verified: forge test passes (78/78).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this May 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7da29137-a63c-4386-a617-6ea885eb755c

📥 Commits

Reviewing files that changed from the base of the PR and between 90ded4a and 198f760.

⛔ Files ignored due to path filters (1)
  • soldeer.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • foundry.toml
  • remappings.txt
  • src/lib/LibFixedPointDecimalArithmeticOpenZeppelin.sol
  • src/lib/LibFixedPointDecimalStrings.sol
  • src/lib/format/LibFixedPointDecimalFormat.sol
  • test/src/lib/FixedPointDecimalArithmeticOpenZeppelin.t.sol

Walkthrough

OpenZeppelin contracts dependency is upgraded from version 4.8.3 to 5.6.1. The Foundry configuration and remappings specify the new version, and all library imports in source files and tests are updated to reference the v5.6.1 paths.

Changes

OpenZeppelin v4.8.3 → v5.6.1 Upgrade

Layer / File(s) Summary
Dependency Configuration
foundry.toml, remappings.txt
@openzeppelin-contracts dependency version updated from 4.8.3 to 5.6.1; remapping path updated to @openzeppelin-contracts-5.6.1/.
Library Imports
src/lib/LibFixedPointDecimalArithmeticOpenZeppelin.sol, src/lib/LibFixedPointDecimalStrings.sol, src/lib/format/LibFixedPointDecimalFormat.sol
Math and Strings imports updated to use OpenZeppelin v5.6.1; library logic and public interfaces remain unchanged.
Test Imports
test/src/lib/FixedPointDecimalArithmeticOpenZeppelin.t.sol
Math import updated to v5.6.1; test logic and assertions remain unchanged.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: upgrading OpenZeppelin Contracts from version 4.8.3 to 5.6.1 across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-10-oz-5.6.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit a535add into main May 9, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Tip

For best results, initiate chat on the files or code changes.

SIZE=S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant