fix copyright #128
fix copyright #128
Conversation
WalkthroughUpdated SPDX FileCopyrightText headers across error, library, and test files to attribute "Rain Open Source Software Ltd" instead of "thedavidmeister". No functional, interface, or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (6)
src/error/ErrDecimalFloat.sol(1 hunks)src/error/ErrParse.sol(1 hunks)src/lib/format/LibFormatDecimalFloat.sol(1 hunks)src/lib/parse/LibParseDecimalFloat.sol(1 hunks)test/src/lib/format/LibFormatDecimalFloat.countSigFigs.t.sol(1 hunks)test/src/lib/format/LibFormatDecimalFloat.toDecimalString.t.sol(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-legal)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-static)
- GitHub Check: rainix (macos-latest, rainix-rs-test)
- GitHub Check: rainix (ubuntu-latest, test-wasm-build)
- GitHub Check: rainix (ubuntu-latest, rainix-rs-static)
- GitHub Check: rainix (macos-latest, rainix-sol-legal)
- GitHub Check: rainix (ubuntu-latest, rainix-rs-test)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-test)
- GitHub Check: git-clean
🔇 Additional comments (1)
src/lib/format/LibFormatDecimalFloat.sol (1)
2-2: SPDX headers verified and up to date. No old attributions remain; every.solfile includes the updatedSPDX-FileCopyrightTextand aSPDX-License-Identifierline.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
LGTM on attribution.
Same optional note about year range if applicable.
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In src/error/ErrDecimalFloat.sol around line 2 the SPDX copyright attribution is
acceptable as-is, but optionally update the SPDX-FileCopyrightText to include an
explicit year or year range (e.g., "2020-2025" or "2020") if your project policy
requires a year range; change the string accordingly and commit the updated SPDX
header, otherwise leave the line unchanged since the reviewer approved it.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Attribution updated correctly.
Consider a year range if contributions continued beyond 2020.
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In src/error/ErrParse.sol around line 2, the SPDX copyright header currently
lists a single year (2020); update it to a year range reflecting continued
contributions (for example "2020-2025" or "2020-present") to correctly attribute
ongoing work, and ensure the SPDX line remains a single-line comment starting
with "// SPDX-FileCopyrightText:" followed by the chosen year range and the
original owner string.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
SPDX copyright holder update looks good.
Consider updating the year to a range if contributions continued after 2020.
Apply if appropriate:
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In src/lib/format/LibFormatDecimalFloat.sol around line 2, the SPDX copyright
header uses a single year (2020); update it to a year range to reflect continued
contributions (e.g., 2020-2025) by replacing the line with the same SPDX header
but with the appropriate end year range for Rain Open Source Software Ltd —
adjust the end year to the latest contribution year and keep the SPDX header
format unchanged.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Header owner change approved.
Apply year range if the file saw commits after 2020.
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In src/lib/parse/LibParseDecimalFloat.sol around line 2, the SPDX copyright
header was changed and needs a year range if the file has commits after 2020;
determine the file's last commit year (e.g., via git log -1 --format=%ad
--date=format:%Y) and update the SPDX header to use a year range from 2020 to
that year (e.g., 2020-2025) while keeping the owner as Rain Open Source Software
Ltd.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Header change acknowledged.
If work spans multiple years, use a year range for accuracy.
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In test/src/lib/format/LibFormatDecimalFloat.countSigFigs.t.sol around line 2,
the SPDX header lists a single year ("2020"); update it to a year range to
reflect multi-year work (for example "2020-2025" or "2020-<current year>") so
the copyright span is accurate; replace the single-year token with the
appropriate start–end range in the SPDX header.
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 thedavidmeister | |||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consistent with the PR intent.
Optional: adjust to a year range for precision.
-// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+// SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | |
| // SPDX-FileCopyrightText: Copyright (c) 2020-2025 Rain Open Source Software Ltd |
🤖 Prompt for AI Agents
In test/src/lib/format/LibFormatDecimalFloat.toDecimalString.t.sol around line
2, the SPDX copyright header currently lists a single year; update it to a year
range for greater precision (e.g., "2020-2025" or the current year) by replacing
the single year with an inclusive range in the SPDX-FileCopyrightText line.
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Oops, something went wrong! Please try again later. 🐰 💔 |
1 participant
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
Chores
Documentation
Tests