-
Notifications
You must be signed in to change notification settings - Fork 0
2025 10 04 float #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37ff56f
update forge-std
thedavidmeister ce2211c
bump nix
thedavidmeister f4a62ef
foundry lock
thedavidmeister a4c95cb
rm deps
thedavidmeister 956068b
bump i9r
thedavidmeister 506b5ca
install i9r
thedavidmeister fa334c1
update deps
thedavidmeister 5c4d0ca
set pyth rev
thedavidmeister 2b33a70
wip on build with new i9r
thedavidmeister f2bcbba
update i9r
thedavidmeister b6e85d1
float for pyth words
thedavidmeister 05f9194
fix legal
thedavidmeister 9cef775
fix static
thedavidmeister 6afd239
slither false positive
thedavidmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,9 @@ | ||
| [submodule "lib/forge-std"] | ||
| path = lib/forge-std | ||
| url = https://github.com/foundry-rs/forge-std | ||
| [submodule "lib/pyth-crosschain"] | ||
| path = lib/pyth-crosschain | ||
| url = https://github.com/pyth-network/pyth-crosschain | ||
| [submodule "lib/rain.math.float"] | ||
| path = lib/rain.math.float | ||
| url = https://github.com/rainlanguage/rain.math.float | ||
| [submodule "lib/rain.interpreter"] | ||
| path = lib/rain.interpreter | ||
| url = https://github.com/rainlanguage/rain.interpreter | ||
| [submodule "lib/pyth-crosschain"] | ||
| path = lib/pyth-crosschain | ||
| url = https://github.com/pyth-network/pyth-crosschain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "lib/forge-std": { | ||
| "rev": "17a9b2398a7d629931dc66a168a098d051d53dc6" | ||
| }, | ||
| "lib/pyth-crosschain": { | ||
| "rev": "6248709ef4f5c20e4fb2828bc68789eb0164df99" | ||
| }, | ||
| "lib/rain.interpreter": { | ||
| "rev": "6068857887731d910f3f1850c5f27248fce3a5d5" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule forge-std
updated
22 files
| +1 −0 | .github/CODEOWNERS | |
| +6 −0 | .github/dependabot.yml | |
| +114 −100 | .github/workflows/ci.yml | |
| +6 −1 | .github/workflows/sync.yml | |
| +1 −1 | README.md | |
| +12 −0 | RELEASE_CHECKLIST.md | |
| +8 −4 | foundry.toml | |
| +1 −1 | package.json | |
| +6 −0 | src/Base.sol | |
| +60 −0 | src/Config.sol | |
| +477 −0 | src/LibVariable.sol | |
| +142 −47 | src/StdAssertions.sol | |
| +1 −0 | src/StdChains.sol | |
| +612 −0 | src/StdConfig.sol | |
| +2 −2 | src/StdStorage.sol | |
| +0 −1 | src/StdUtils.sol | |
| +113 −16 | src/Vm.sol | |
| +352 −0 | test/Config.t.sol | |
| +434 −0 | test/LibVariable.t.sol | |
| +1 −1 | test/StdChains.t.sol | |
| +1 −1 | test/Vm.t.sol | |
| +81 −0 | test/fixtures/config.toml |
Submodule pyth-crosschain
updated
924 files
Submodule rain.interpreter
updated
408 files
Submodule rain.math.float
deleted from
b506dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Output array construction is correct; optional high-level alternative
The memory layout (len + 2 elements) and free memory pointer advance are correct.
Optional for readability:
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that costs more gas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thedavidmeister, understood! The inline assembly approach is more gas-efficient. I'll note that the current implementation is optimal for performance.