Fix scenario blocks field parsing bug#1646
Merged
Conversation
Contributor
WalkthroughThe pull request modifies block configuration processing in two ways. In Changes
Sequence Diagram(s)sequenceDiagram
participant YAML
participant Parser
participant Validator
YAML->>Parser: Provide YAML scenario config with blocks field
alt blocks provided as string
Parser->>Validator: Validate blocks string format
else blocks provided as hash
Parser->>Parser: Extract "range" and "interval" using get_hash_value
Parser->>Validator: Validate constructed blocks string
end
Validator-->>Parser: Return validation result
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningscrates/settings/src/scenario.rs (1)⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
crates/settings/src/blocks.rs(1 hunks)crates/settings/src/scenario.rs(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build-tauri (ubuntu-22.04, true)
- GitHub Check: test
- GitHub Check: test
- GitHub Check: git-clean
🔇 Additional comments (1)
crates/settings/src/scenario.rs (1)
560-563: These imports appear valid and are used in subsequent tests.
No issues noted; the added imports forBlockCfg,BlockRangeCfg, andmock_deployerare appropriate for the tested functionality.
4 tasks
hardyjosh
approved these changes
Apr 10, 2025
4 tasks
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See issue: #1644
Solution
validate_blocksfunction to get correctBlockCfgvalueChecks
By submitting this for review, I'm confirming I've done the following:
fix #1644
Summary by CodeRabbit
New Features
Refactor
Tests