Skip to content

V5 Upgrade#1911

Merged
hardyjosh merged 173 commits into2024-09-12-i9rfrom
upd/alloy
Jul 26, 2025
Merged

V5 Upgrade#1911
hardyjosh merged 173 commits into2024-09-12-i9rfrom
upd/alloy

Conversation

@0xgleb
Copy link
Copy Markdown
Collaborator

@0xgleb 0xgleb commented Jun 6, 2025

Warning

Not all orders/networks have been deployed/updated in rain.strategies

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Upgraded to Orderbook v5 with updated data types and floating-point support for balances, ratios, and amounts.
    • Added new Solidity and floating-point configuration options.
    • Introduced improved error handling and messaging across CLI, JS API, and webapp.
  • Bug Fixes

    • Enhanced parsing and formatting of numeric values, especially balances and ratios.
    • Fixed test assertions and error message consistency.
  • Refactor

    • Migrated vault, trade, and quote calculations from integer to floating-point arithmetic.
    • Updated contract bindings and interfaces to latest versions.
    • Simplified ERC20 interactions and multicall logic.
    • Modernized test fixtures and local EVM provider usage.
    • Replaced custom allowance and approval logic with direct ERC20 contract calls and ABI encoding.
    • Streamlined deposit and withdraw calldata generation using new ABI structs.
    • Refined ledger client creation and transaction argument handling for improved error propagation.
  • Chores

    • Disabled/commented UI components and tests related to order performance and vault volume (issue Implement performance metrics with floats #1989).
    • Updated dependencies, configs, and code formatting for consistency.
    • Added new floating-point constants and utilities for consistent numeric handling.
  • Documentation

    • Clarified comments and error messages.
  • Style

    • Standardized code style and naming conventions.
    • Reformatted shell scripts and build scripts for readability.
  • Tests

    • Revised test data to use hex-encoded and floating-point formats.
    • Disabled certain UI and performance-related tests per issue Implement performance metrics with floats #1989.
    • Updated tests to reflect new orderbook bindings and floating-point types.
    • Improved test error handling and temporary file usage.
  • Revert

    • Temporarily commented out UI components and calculations pending further updates.

@0xgleb 0xgleb self-assigned this Jun 6, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 6, 2025

Caution

Review failed

Failed to post review comments.

Walkthrough

This change updates the REGISTRY_URL constant in packages/webapp/src/lib/constants.ts to reference a different commit hash in the Rain Strategies GitHub raw content URL. No other code, logic, or configuration is modified.

Changes

File Change Summary
packages/webapp/src/lib/constants.ts Updated the REGISTRY_URL constant to a new commit hash.

Sequence Diagram(s)

Not applicable for this simple constant update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

rust

Suggested reviewers

  • hardyjosh

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-26T12_16_43_838Z-debug-0.log

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upd/alloy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xgleb 0xgleb mentioned this pull request Jun 6, 2025
23 tasks
@0xgleb 0xgleb changed the title upgrade dep versions, wip build fixes Update alloy and rain deps Jun 7, 2025
@0xgleb 0xgleb changed the base branch from main to 2024-09-12-i9r June 8, 2025 14:41
@0xgleb
Copy link
Copy Markdown
Collaborator Author

0xgleb commented Jul 26, 2025

@CodeRabbit full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 26, 2025

✅ Actions performed

Full review triggered.

@0xgleb
Copy link
Copy Markdown
Collaborator Author

0xgleb commented Jul 26, 2025

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 26, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@hardyjosh hardyjosh merged commit 62506e0 into 2024-09-12-i9r Jul 26, 2025
18 checks passed
@0xgleb 0xgleb deleted the upd/alloy branch July 26, 2025 15:18
This was referenced Oct 23, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Dec 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants