-
Notifications
You must be signed in to change notification settings - Fork 18
Add withdraw all buttons on Order Details page #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
c91f4dd
feat: add "Withdraw all" buttons
brusherru b71489c
refactor: get rid of excessive arg `entity` in TransactionConfirmatio…
brusherru 451ea05
feat: implement `generate_multicall_calldata`
brusherru 39ca006
feat: integrate multiple vaults withdraw to order details page
brusherru 14dba86
tweak: do not show "Withdraw all" button for vaults with 0 balance
brusherru 8ea6431
feat: integrate withdraw all functionality on the Vaults page
brusherru cd18e96
tweak: improve displaying of withdrawal buttons on OrderDetails page
brusherru 6bc4d85
tweak: improve GUI on Vaults list page
brusherru 411f504
feat: integrate same functionality in Tauri-app
brusherru 2c4e753
tweak: ensure that all vaults are in the same orderbook
brusherru 3bed777
refactor: extract hardcoded `4` into `TRANSACTION_CONFIRMATIONS` cons…
brusherru 72448db
tweak: enrich tooltip of disabled checkbox on Vaults page
brusherru b8dfd4c
tweak: invalidate all vaults after withdraw multiple vaults
brusherru 9942056
fix: raise z-index of Tooltip
brusherru 0ba07b5
fix: bring reactivity to showing/hiding "Withdraw all" buttons when w…
brusherru 8884329
refactor: move `multicall` outside of `gui` module
brusherru 7c81392
refactor: add input validation and tests for `generate_multicall_call…
brusherru c27fa21
refactor: re-use RaindexVaultType and extract VaultsGroupedByType
brusherru 1acbb8c
tweak: drop vault selection only after signing tx
brusherru 4e4886c
chore: update docs comment
brusherru 011fbc0
refactor: bunch of tiny changes due to comments
brusherru fe996d4
chore: fix prettier
brusherru 165893b
refactor: fix OrderDetail tests
brusherru 2b93f42
fix: handle deseleting vaults on successfull withdraw properly in Tau…
brusherru 80c8e4a
refactor: get rid of defaults for impossible undefined
brusherru 8baac13
refactor: simplified reduce function as proposed
brusherru dec5a5b
chore: fix linting error
brusherru 470e878
chore: update JSDoc
brusherru 169f04a
fix: show hex-encoded vaultId on WithdrawAll modal
brusherru ebc38f3
chore: update JSDoc
brusherru 65d0f25
refactor: get rid of excessive div nesting
brusherru 757b707
tweak: add validation that all vaults belongs to the same orderbook
brusherru 6e81edc
tweak: disable/enable checkbox on Vaults page reactively
brusherru 591ac24
feat: add "Reset withdraw selection" button
brusherru c017ca0
feat: implement VaultsList struct
brusherru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider re-exporting
VaultsListfor a flatter public APIDown-stream crates / WASM consumers will now need to write
raindex_client::vaults_list::VaultsList, whereas all other helpers are already exposed at the crate root (e.g.vaults).Staying consistent keeps the TS/WASM surface intuitive.
📝 Committable suggestion
🤖 Prompt for AI Agents