Add local db table schemas and insert command generation#2101
Merged
Add local db table schemas and insert command generation#2101
Conversation
Contributor
WalkthroughAdds a new SQLite insert pipeline that converts decoded events into SQL statements and transaction batches, introduces a public InsertError and decoded_events_to_sql API, exposes the insert module, defines the SQLite schema for all related tables and indexes, and removes the OrderHashComputation variant from DecodeError. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Insert as sqlite_web::insert
participant Gen as Per-Event Generators
participant SQL as SQL Buffer
Caller->>Insert: decoded_events_to_sql(events, end_block)
Insert->>Insert: Build EventContext per event
loop For each event
Insert->>Gen: Dispatch generate_*_sql(event, ctx)
Gen->>Gen: Compute order hashes / convert fields
Gen->>SQL: Append INSERTs (+ child rows)
end
Insert->>SQL: Append sync_status update + COMMIT
Insert-->>Caller: Ok(SQL string) or Err(InsertError)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
This was
linked to
issues
Aug 27, 2025
findolor
changed the title
4 tasks
hardyjosh
approved these changes
Sep 26, 2025
0xgleb
approved these changes
Oct 1, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
crates/common/src/raindex_client/sqlite_web/decode.rs(0 hunks)crates/common/src/raindex_client/sqlite_web/insert.rs(1 hunks)crates/common/src/raindex_client/sqlite_web/mod.rs(1 hunks)crates/common/src/raindex_client/sqlite_web/sql/tables.sql(1 hunks)
💤 Files with no reviewable changes (1)
- crates/common/src/raindex_client/sqlite_web/decode.rs
🧰 Additional context used
📓 Path-based instructions (1)
crates/**/{src,tests,benches,examples}/**/*.rs
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
crates/**/{src,tests,benches,examples}/**/*.rs: Rust crates: lint withcargo clippy --workspace --all-targets --all-features -D warnings
Rust crates: ensurecargo test --workspacepasses
Rust crates: build withcargo buildduring development/readiness checks
Files:
crates/common/src/raindex_client/sqlite_web/mod.rscrates/common/src/raindex_client/sqlite_web/insert.rs
🧬 Code graph analysis (1)
crates/common/src/raindex_client/sqlite_web/insert.rs (2)
crates/common/src/raindex_client/sqlite_web/decode.rs (2)
U256(225-225)event(169-178)subgraph/tests/event-mocks.test.ts (1)
IOV2(115-123)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: standard-tests (ubuntu-latest, test-js-bindings)
- GitHub Check: build-tauri (ubuntu-22.04, true)
- GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-test)
- GitHub Check: standard-tests (ubuntu-latest, rainix-sol-artifacts)
- GitHub Check: standard-tests (ubuntu-latest, rainix-rs-static)
- GitHub Check: standard-tests (ubuntu-latest, rainix-rs-artifacts, true)
- GitHub Check: Deploy-Docs-Preview
- GitHub Check: Deploy-Preview-Push
- GitHub Check: copilot-setup-steps
🔇 Additional comments (5)
crates/common/src/raindex_client/sqlite_web/mod.rs (1)
3-3: Expose module looks goodpub mod insert; correctly surfaces the new API. No further changes needed here.
crates/common/src/raindex_client/sqlite_web/insert.rs (3)
73-82: Guard against SQLite INTEGER rangeSQLite INTEGER is signed 64-bit. If future block_number/log_index exceed i64::MAX, writes may misbehave. Add a range check or store as TEXT.
Would you like a small guard that errors when value > i64::MAX?
384-417: Order IOs generation is solidCorrectly splits inputs/outputs, resets indices per io_type, and batches into a single INSERT.
419-424: Hex parsing helper is fineHandles 0x-optional prefix and errors cleanly.
crates/common/src/raindex_client/sqlite_web/sql/tables.sql (1)
121-130: Keep BLOB for meta; ensure insertion uses X'…'Schema is fine as BLOB. After adjusting the insert to X'…', this will be consistent.
Comment on lines
+125
to
+131
| DecodedEvent::Unknown(decoded) => { | ||
| eprintln!( | ||
| "Warning: Unknown event type for transaction {}: {}", | ||
| event.transaction_hash, decoded.note | ||
| ); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Use structured logging instead of eprintln
Replace eprintln! with tracing/log for production observability and tests.
- eprintln!(
+ tracing::warn!(
"Warning: Unknown event type for transaction {}: {}",
event.transaction_hash, decoded.note
);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| DecodedEvent::Unknown(decoded) => { | |
| eprintln!( | |
| "Warning: Unknown event type for transaction {}: {}", | |
| event.transaction_hash, decoded.note | |
| ); | |
| } | |
| } | |
| DecodedEvent::Unknown(decoded) => { | |
| tracing::warn!( | |
| "Warning: Unknown event type for transaction {}: {}", | |
| event.transaction_hash, | |
| decoded.note | |
| ); | |
| } | |
| } |
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/insert.rs around lines 125 to
131, replace the eprintln! call in the DecodedEvent::Unknown arm with structured
logging (e.g., tracing::warn! or log::warn!) and include structured fields for
easier observability: pass the transaction hash and the decoded.note as named
fields instead of formatting into a string. Ensure the tracing (or log) crate is
in scope (add use tracing::warn; or use log::warn;) and that the crate
features/dependencies and tests are updated to initialize the logger/tracing
subscriber where needed so tests still run.
Comment on lines
+134
to
+140
| sql.push_str(&format!( | ||
| "\nUPDATE sync_status SET last_synced_block = {}, updated_at = CURRENT_TIMESTAMP WHERE id = 1;\n", | ||
| end_block | ||
| )); | ||
|
|
||
| sql.push_str("\nCOMMIT;\n"); | ||
|
|
Contributor
There was a problem hiding this comment.
sync_status update will fail if table/row doesn’t exist; use UPSERT
The UPDATE assumes a pre-existing row id=1. Prefer an UPSERT to initialize and update atomically.
Apply this diff:
- sql.push_str(&format!(
- "\nUPDATE sync_status SET last_synced_block = {}, updated_at = CURRENT_TIMESTAMP WHERE id = 1;\n",
- end_block
- ));
+ sql.push_str(&format!(
+ "\nINSERT INTO sync_status (id, last_synced_block, updated_at) VALUES (1, {}, CURRENT_TIMESTAMP)\n\
+ON CONFLICT(id) DO UPDATE SET last_synced_block = {}, updated_at = CURRENT_TIMESTAMP;\n",
+ end_block, end_block
+ ));📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| sql.push_str(&format!( | |
| "\nUPDATE sync_status SET last_synced_block = {}, updated_at = CURRENT_TIMESTAMP WHERE id = 1;\n", | |
| end_block | |
| )); | |
| sql.push_str("\nCOMMIT;\n"); | |
| sql.push_str(&format!( | |
| "\nINSERT INTO sync_status (id, last_synced_block, updated_at) \ | |
| VALUES (1, {}, CURRENT_TIMESTAMP)\n\ | |
| ON CONFLICT(id) DO UPDATE SET last_synced_block = {}, updated_at = CURRENT_TIMESTAMP;\n", | |
| end_block, end_block | |
| )); | |
| sql.push_str("\nCOMMIT;\n"); |
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/insert.rs around lines 134 to
140, the code issues an UPDATE on sync_status row id=1 which will fail if the
table or row doesn't exist; replace the UPDATE with an UPSERT that atomically
creates or updates the row. Concretely, remove the UPDATE statement and append
an INSERT ... ON CONFLICT(id) DO UPDATE (or SQLite's INSERT OR REPLACE/INSERT
... ON CONFLICT) that sets id=1, last_synced_block to end_block and updated_at
to CURRENT_TIMESTAMP so the row is initialized when missing and updated
otherwise while remaining inside the same transaction.
Comment on lines
+232
to
+285
| fn generate_take_order_sql( | ||
| context: &EventContext<'_>, | ||
| decoded: &TakeOrderV3, | ||
| ) -> Result<String, InsertError> { | ||
| let input_io_index_u64 = u256_to_u64(&decoded.config.inputIOIndex, "inputIOIndex")?; | ||
| let output_io_index_u64 = u256_to_u64(&decoded.config.outputIOIndex, "outputIOIndex")?; | ||
|
|
||
| let mut sql = String::new(); | ||
|
|
||
| sql.push_str(&format!( | ||
| "INSERT INTO take_orders (block_number, block_timestamp, transaction_hash, log_index, sender, order_owner, order_nonce, input_io_index, output_io_index, input, output) VALUES ({}, {}, '{}', {}, '{}', '{}', '{}', {}, {}, '{}', '{}');\n", | ||
| context.block_number, | ||
| context.block_timestamp, | ||
| context.transaction_hash, | ||
| context.log_index, | ||
| hex::encode_prefixed(decoded.sender), | ||
| hex::encode_prefixed(decoded.config.order.owner), | ||
| hex::encode_prefixed(decoded.config.order.nonce), | ||
| input_io_index_u64, | ||
| output_io_index_u64, | ||
| hex::encode_prefixed(decoded.input), | ||
| hex::encode_prefixed(decoded.output) | ||
| )); | ||
|
|
||
| for (context_index, signed_context) in decoded.config.signedContext.iter().enumerate() { | ||
| let context_value = format!( | ||
| "signer:{},signature:{}", | ||
| hex::encode_prefixed(signed_context.signer), | ||
| hex::encode_prefixed(&signed_context.signature) | ||
| ); | ||
|
|
||
| sql.push_str(&format!( | ||
| "INSERT INTO take_order_contexts (transaction_hash, log_index, context_index, context_value) VALUES ('{}', {}, {}, '{}');\n", | ||
| context.transaction_hash, | ||
| context.log_index, | ||
| context_index, | ||
| context_value | ||
| )); | ||
|
|
||
| for (value_index, value) in signed_context.context.iter().enumerate() { | ||
| sql.push_str(&format!( | ||
| "INSERT INTO context_values (transaction_hash, log_index, context_index, value_index, value) VALUES ('{}', {}, {}, {}, '{}');\n", | ||
| context.transaction_hash, | ||
| context.log_index, | ||
| context_index, | ||
| value_index, | ||
| hex::encode_prefixed(value) | ||
| )); | ||
| } | ||
| } | ||
|
|
||
| Ok(sql) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Context serialization: consider first-class columns for signer/signature
Packing signer/signature into a single TEXT forces downstream parsing. Adding columns (signer, signature) to take_order_contexts would be cleaner and indexable.
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/insert.rs around lines 232 to
285, the current code packs signer and signature into a single TEXT
context_value which forces downstream parsing; change the INSERT into
take_order_contexts to use two first-class columns (signer, signature) instead
of a single context_value, inserting hex::encode_prefixed(signed_context.signer)
and hex::encode_prefixed(&signed_context.signature) into those columns, remove
the combined context_value insertion, update any schema/migration to add signer
and signature columns (and drop/mark context_value as deprecated if desired),
and update any downstream consumers/tests to read the new columns; keep the
existing loop for signed_context.context values unchanged but ensure
transaction_hash/log_index/context_index semantics remain the same.
Comment on lines
+368
to
+382
| fn generate_meta_sql( | ||
| context: &EventContext<'_>, | ||
| decoded: &MetaV1_2, | ||
| ) -> Result<String, InsertError> { | ||
| Ok(format!( | ||
| "INSERT INTO meta_events (block_number, block_timestamp, transaction_hash, log_index, sender, subject, meta) VALUES ({}, {}, '{}', {}, '{}', '{}', '{}');\n", | ||
| context.block_number, | ||
| context.block_timestamp, | ||
| context.transaction_hash, | ||
| context.log_index, | ||
| hex::encode_prefixed(decoded.sender), | ||
| hex::encode_prefixed(decoded.subject), | ||
| hex::encode_prefixed(&decoded.meta) | ||
| )) | ||
| } |
Contributor
There was a problem hiding this comment.
Insert BLOB correctly (use X'…' literal), not a quoted 0x hex string
meta_events.meta is BLOB, but the current SQL inserts TEXT ('0x…'). Use an SQLite BLOB literal.
Apply this diff:
- Ok(format!(
- "INSERT INTO meta_events (block_number, block_timestamp, transaction_hash, log_index, sender, subject, meta) VALUES ({}, {}, '{}', {}, '{}', '{}', '{}');\n",
- context.block_number,
- context.block_timestamp,
- context.transaction_hash,
- context.log_index,
- hex::encode_prefixed(decoded.sender),
- hex::encode_prefixed(decoded.subject),
- hex::encode_prefixed(&decoded.meta)
- ))
+ let meta_hex = hex::encode(&decoded.meta); // no 0x prefix
+ Ok(format!(
+ "INSERT INTO meta_events (block_number, block_timestamp, transaction_hash, log_index, sender, subject, meta) VALUES ({}, {}, '{}', {}, '{}', '{}', X'{}');\n",
+ context.block_number,
+ context.block_timestamp,
+ context.transaction_hash,
+ context.log_index,
+ hex::encode_prefixed(decoded.sender),
+ hex::encode_prefixed(decoded.subject),
+ meta_hex
+ ))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| fn generate_meta_sql( | |
| context: &EventContext<'_>, | |
| decoded: &MetaV1_2, | |
| ) -> Result<String, InsertError> { | |
| Ok(format!( | |
| "INSERT INTO meta_events (block_number, block_timestamp, transaction_hash, log_index, sender, subject, meta) VALUES ({}, {}, '{}', {}, '{}', '{}', '{}');\n", | |
| context.block_number, | |
| context.block_timestamp, | |
| context.transaction_hash, | |
| context.log_index, | |
| hex::encode_prefixed(decoded.sender), | |
| hex::encode_prefixed(decoded.subject), | |
| hex::encode_prefixed(&decoded.meta) | |
| )) | |
| } | |
| fn generate_meta_sql( | |
| context: &EventContext<'_>, | |
| decoded: &MetaV1_2, | |
| ) -> Result<String, InsertError> { | |
| let meta_hex = hex::encode(&decoded.meta); // no 0x prefix | |
| Ok(format!( | |
| "INSERT INTO meta_events (block_number, block_timestamp, transaction_hash, log_index, sender, subject, meta) VALUES ({}, {}, '{}', {}, '{}', '{}', X'{}');\n", | |
| context.block_number, | |
| context.block_timestamp, | |
| context.transaction_hash, | |
| context.log_index, | |
| hex::encode_prefixed(decoded.sender), | |
| hex::encode_prefixed(decoded.subject), | |
| meta_hex | |
| )) | |
| } |
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/insert.rs around lines 368 to
382, meta_events.meta is a BLOB but the SQL currently inserts it as a quoted 0x
hex string; change the INSERT to use an SQLite BLOB literal X'hex' instead of a
quoted '0x…' value. Concretely, stop using hex::encode_prefixed(...) for
decoded.meta (which yields a "0x" prefix) and instead use
hex::encode(&decoded.meta) and embed it in the SQL as X'{hex}' (no surrounding
single quotes) so the meta column receives a true BLOB literal; update the
format string to remove the single quotes around the meta placeholder and wrap
that placeholder with X'{}' while leaving sender/subject handling unchanged.
Comment on lines
+1
to
+156
| CREATE TABLE deposits ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| token TEXT NOT NULL, | ||
| vault_id TEXT NOT NULL, | ||
| deposit_amount_uint256 TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE withdrawals ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| token TEXT NOT NULL, | ||
| vault_id TEXT NOT NULL, | ||
| target_amount TEXT NOT NULL, | ||
| withdraw_amount TEXT NOT NULL, | ||
| withdraw_amount_uint256 TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE order_events ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| order_hash TEXT NOT NULL, | ||
| event_type TEXT NOT NULL, | ||
| order_owner TEXT NOT NULL, | ||
| order_nonce TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE order_ios ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| io_index INTEGER NOT NULL, | ||
| io_type TEXT NOT NULL, | ||
| token TEXT NOT NULL, | ||
| vault_id TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | ||
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE take_orders ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| order_owner TEXT NOT NULL, | ||
| order_nonce TEXT NOT NULL, | ||
| input_io_index INTEGER NOT NULL, | ||
| output_io_index INTEGER NOT NULL, | ||
| input TEXT NOT NULL, | ||
| output TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE take_order_contexts ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| context_index INTEGER NOT NULL, | ||
| context_value TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index, context_index), | ||
| FOREIGN KEY (transaction_hash, log_index) REFERENCES take_orders(transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE context_values ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| context_index INTEGER NOT NULL, | ||
| value_index INTEGER NOT NULL, | ||
| value TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index, context_index, value_index), | ||
| FOREIGN KEY (transaction_hash, log_index, context_index) REFERENCES take_order_contexts(transaction_hash, log_index, context_index) | ||
| ); | ||
|
|
||
| CREATE TABLE clear_v3_events ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| alice_order_hash TEXT NOT NULL, | ||
| alice_order_owner TEXT NOT NULL, | ||
| alice_input_io_index INTEGER NOT NULL, | ||
| alice_output_io_index INTEGER NOT NULL, | ||
| alice_bounty_vault_id TEXT NOT NULL, | ||
| alice_input_vault_id TEXT NOT NULL, | ||
| alice_output_vault_id TEXT NOT NULL, | ||
| bob_order_hash TEXT NOT NULL, | ||
| bob_order_owner TEXT NOT NULL, | ||
| bob_input_io_index INTEGER NOT NULL, | ||
| bob_output_io_index INTEGER NOT NULL, | ||
| bob_bounty_vault_id TEXT NOT NULL, | ||
| bob_input_vault_id TEXT NOT NULL, | ||
| bob_output_vault_id TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE after_clear_v2_events ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| alice_output TEXT NOT NULL, | ||
| bob_output TEXT NOT NULL, | ||
| alice_input TEXT NOT NULL, | ||
| bob_input TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
|
|
||
| CREATE TABLE meta_events ( | ||
| transaction_hash TEXT NOT NULL, | ||
| log_index INTEGER NOT NULL, | ||
| block_number INTEGER NOT NULL, | ||
| block_timestamp INTEGER NOT NULL, | ||
| sender TEXT NOT NULL, | ||
| subject TEXT NOT NULL, | ||
| meta BLOB NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index) | ||
| ); | ||
| CREATE INDEX idx_deposits_vault ON deposits(sender, token, vault_id); | ||
| CREATE INDEX idx_deposits_block ON deposits(block_number); | ||
| CREATE INDEX idx_deposits_token ON deposits(token); | ||
|
|
||
| CREATE INDEX idx_withdrawals_vault ON withdrawals(sender, token, vault_id); | ||
| CREATE INDEX idx_withdrawals_block ON withdrawals(block_number); | ||
| CREATE INDEX idx_withdrawals_token ON withdrawals(token); | ||
|
|
||
| CREATE INDEX idx_order_events_hash ON order_events(order_hash); | ||
| CREATE INDEX idx_order_events_owner ON order_events(order_owner); | ||
| CREATE INDEX idx_order_events_block ON order_events(block_number); | ||
|
|
||
| CREATE INDEX idx_order_ios_token ON order_ios(token); | ||
|
|
||
| CREATE INDEX idx_take_orders_owner ON take_orders(order_owner); | ||
| CREATE INDEX idx_take_orders_block ON take_orders(block_number); | ||
|
|
||
| CREATE INDEX idx_clear_events_alice_bob ON clear_v3_events(alice_order_hash, bob_order_hash); | ||
| CREATE INDEX idx_clear_events_block ON clear_v3_events(block_number); | ||
| CREATE INDEX idx_clear_alice_vaults ON clear_v3_events(alice_input_vault_id, alice_output_vault_id); | ||
| CREATE INDEX idx_clear_bob_vaults ON clear_v3_events(bob_input_vault_id, bob_output_vault_id); | ||
|
|
||
| CREATE INDEX idx_after_clear_block ON after_clear_v2_events(block_number); | ||
|
|
||
| CREATE INDEX idx_meta_subject ON meta_events(subject); | ||
| CREATE INDEX idx_meta_block ON meta_events(block_number); No newline at end of file |
Contributor
There was a problem hiding this comment.
Add sync_status table to match generated SQL
decoded_events_to_sql updates sync_status, but schema lacks it. Add a small table with singleton id=1.
Append this near the top:
+CREATE TABLE IF NOT EXISTS sync_status (
+ id INTEGER PRIMARY KEY CHECK (id = 1),
+ last_synced_block INTEGER NOT NULL DEFAULT 0,
+ updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP
+);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| CREATE TABLE deposits ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| deposit_amount_uint256 TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE withdrawals ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| target_amount TEXT NOT NULL, | |
| withdraw_amount TEXT NOT NULL, | |
| withdraw_amount_uint256 TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE order_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| order_hash TEXT NOT NULL, | |
| event_type TEXT NOT NULL, | |
| order_owner TEXT NOT NULL, | |
| order_nonce TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE order_ios ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| io_index INTEGER NOT NULL, | |
| io_type TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | |
| ); | |
| CREATE TABLE take_orders ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| order_owner TEXT NOT NULL, | |
| order_nonce TEXT NOT NULL, | |
| input_io_index INTEGER NOT NULL, | |
| output_io_index INTEGER NOT NULL, | |
| input TEXT NOT NULL, | |
| output TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE take_order_contexts ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| context_index INTEGER NOT NULL, | |
| context_value TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, context_index), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES take_orders(transaction_hash, log_index) | |
| ); | |
| CREATE TABLE context_values ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| context_index INTEGER NOT NULL, | |
| value_index INTEGER NOT NULL, | |
| value TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, context_index, value_index), | |
| FOREIGN KEY (transaction_hash, log_index, context_index) REFERENCES take_order_contexts(transaction_hash, log_index, context_index) | |
| ); | |
| CREATE TABLE clear_v3_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| alice_order_hash TEXT NOT NULL, | |
| alice_order_owner TEXT NOT NULL, | |
| alice_input_io_index INTEGER NOT NULL, | |
| alice_output_io_index INTEGER NOT NULL, | |
| alice_bounty_vault_id TEXT NOT NULL, | |
| alice_input_vault_id TEXT NOT NULL, | |
| alice_output_vault_id TEXT NOT NULL, | |
| bob_order_hash TEXT NOT NULL, | |
| bob_order_owner TEXT NOT NULL, | |
| bob_input_io_index INTEGER NOT NULL, | |
| bob_output_io_index INTEGER NOT NULL, | |
| bob_bounty_vault_id TEXT NOT NULL, | |
| bob_input_vault_id TEXT NOT NULL, | |
| bob_output_vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE after_clear_v2_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| alice_output TEXT NOT NULL, | |
| bob_output TEXT NOT NULL, | |
| alice_input TEXT NOT NULL, | |
| bob_input TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE meta_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| subject TEXT NOT NULL, | |
| meta BLOB NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE INDEX idx_deposits_vault ON deposits(sender, token, vault_id); | |
| CREATE INDEX idx_deposits_block ON deposits(block_number); | |
| CREATE INDEX idx_deposits_token ON deposits(token); | |
| CREATE INDEX idx_withdrawals_vault ON withdrawals(sender, token, vault_id); | |
| CREATE INDEX idx_withdrawals_block ON withdrawals(block_number); | |
| CREATE INDEX idx_withdrawals_token ON withdrawals(token); | |
| CREATE INDEX idx_order_events_hash ON order_events(order_hash); | |
| CREATE INDEX idx_order_events_owner ON order_events(order_owner); | |
| CREATE INDEX idx_order_events_block ON order_events(block_number); | |
| CREATE INDEX idx_order_ios_token ON order_ios(token); | |
| CREATE INDEX idx_take_orders_owner ON take_orders(order_owner); | |
| CREATE INDEX idx_take_orders_block ON take_orders(block_number); | |
| CREATE INDEX idx_clear_events_alice_bob ON clear_v3_events(alice_order_hash, bob_order_hash); | |
| CREATE INDEX idx_clear_events_block ON clear_v3_events(block_number); | |
| CREATE INDEX idx_clear_alice_vaults ON clear_v3_events(alice_input_vault_id, alice_output_vault_id); | |
| CREATE INDEX idx_clear_bob_vaults ON clear_v3_events(bob_input_vault_id, bob_output_vault_id); | |
| CREATE INDEX idx_after_clear_block ON after_clear_v2_events(block_number); | |
| CREATE INDEX idx_meta_subject ON meta_events(subject); | |
| CREATE INDEX idx_meta_block ON meta_events(block_number); | |
| CREATE TABLE IF NOT EXISTS sync_status ( | |
| id INTEGER PRIMARY KEY CHECK (id = 1), | |
| last_synced_block INTEGER NOT NULL DEFAULT 0, | |
| updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP | |
| ); | |
| CREATE TABLE deposits ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| deposit_amount_uint256 TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE withdrawals ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| target_amount TEXT NOT NULL, | |
| withdraw_amount TEXT NOT NULL, | |
| withdraw_amount_uint256 TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE order_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| order_hash TEXT NOT NULL, | |
| event_type TEXT NOT NULL, | |
| order_owner TEXT NOT NULL, | |
| order_nonce TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE order_ios ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| io_index INTEGER NOT NULL, | |
| io_type TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | |
| ); | |
| CREATE TABLE take_orders ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| order_owner TEXT NOT NULL, | |
| order_nonce TEXT NOT NULL, | |
| input_io_index INTEGER NOT NULL, | |
| output_io_index INTEGER NOT NULL, | |
| input TEXT NOT NULL, | |
| output TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE take_order_contexts ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| context_index INTEGER NOT NULL, | |
| context_value TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, context_index), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES take_orders(transaction_hash, log_index) | |
| ); | |
| CREATE TABLE context_values ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| context_index INTEGER NOT NULL, | |
| value_index INTEGER NOT NULL, | |
| value TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, context_index, value_index), | |
| FOREIGN KEY (transaction_hash, log_index, context_index) REFERENCES take_order_contexts(transaction_hash, log_index, context_index) | |
| ); | |
| CREATE TABLE clear_v3_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| alice_order_hash TEXT NOT NULL, | |
| alice_order_owner TEXT NOT NULL, | |
| alice_input_io_index INTEGER NOT NULL, | |
| alice_output_io_index INTEGER NOT NULL, | |
| alice_bounty_vault_id TEXT NOT NULL, | |
| alice_input_vault_id TEXT NOT NULL, | |
| alice_output_vault_id TEXT NOT NULL, | |
| bob_order_hash TEXT NOT NULL, | |
| bob_order_owner TEXT NOT NULL, | |
| bob_input_io_index INTEGER NOT NULL, | |
| bob_output_io_index INTEGER NOT NULL, | |
| bob_bounty_vault_id TEXT NOT NULL, | |
| bob_input_vault_id TEXT NOT NULL, | |
| bob_output_vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE after_clear_v2_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| alice_output TEXT NOT NULL, | |
| bob_output TEXT NOT NULL, | |
| alice_input TEXT NOT NULL, | |
| bob_input TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE TABLE meta_events ( | |
| transaction_hash TEXT NOT NULL, | |
| log_index INTEGER NOT NULL, | |
| block_number INTEGER NOT NULL, | |
| block_timestamp INTEGER NOT NULL, | |
| sender TEXT NOT NULL, | |
| subject TEXT NOT NULL, | |
| meta BLOB NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index) | |
| ); | |
| CREATE INDEX idx_deposits_vault ON deposits(sender, token, vault_id); | |
| CREATE INDEX idx_deposits_block ON deposits(block_number); | |
| CREATE INDEX idx_deposits_token ON deposits(token); | |
| CREATE INDEX idx_withdrawals_vault ON withdrawals(sender, token, vault_id); | |
| CREATE INDEX idx_withdrawals_block ON withdrawals(block_number); | |
| CREATE INDEX idx_withdrawals_token ON withdrawals(token); | |
| CREATE INDEX idx_order_events_hash ON order_events(order_hash); | |
| CREATE INDEX idx_order_events_owner ON order_events(order_owner); | |
| CREATE INDEX idx_order_events_block ON order_events(block_number); | |
| CREATE INDEX idx_order_ios_token ON order_ios(token); | |
| CREATE INDEX idx_take_orders_owner ON take_orders(order_owner); | |
| CREATE INDEX idx_take_orders_block ON take_orders(block_number); | |
| CREATE INDEX idx_clear_events_alice_bob ON clear_v3_events(alice_order_hash, bob_order_hash); | |
| CREATE INDEX idx_clear_events_block ON clear_v3_events(block_number); | |
| CREATE INDEX idx_clear_alice_vaults ON clear_v3_events(alice_input_vault_id, alice_output_vault_id); | |
| CREATE INDEX idx_clear_bob_vaults ON clear_v3_events(bob_input_vault_id, bob_output_vault_id); | |
| CREATE INDEX idx_after_clear_block ON after_clear_v2_events(block_number); | |
| CREATE INDEX idx_meta_subject ON meta_events(subject); | |
| CREATE INDEX idx_meta_block ON meta_events(block_number); |
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/sql/tables.sql around lines 1 to
156, the schema is missing the sync_status table referenced by
decoded_events_to_sql; add a small singleton table named sync_status (with id
constrained to 1 as the primary key and columns to store the last synced block
number and a timestamp/updated_at) near the top of the file so the application
can read/update sync progress; ensure id is defined as INTEGER PRIMARY KEY with
a CHECK(id=1) (or equivalent) to enforce the single-row invariant and include
NOT NULL on the status fields.
Comment on lines
+44
to
+49
| io_type TEXT NOT NULL, | ||
| token TEXT NOT NULL, | ||
| vault_id TEXT NOT NULL, | ||
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | ||
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | ||
| ); |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Constrain io_type values
Add a CHECK to ensure only 'input' or 'output' are stored.
- io_type TEXT NOT NULL,
+ io_type TEXT NOT NULL CHECK (io_type IN ('input','output')),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| io_type TEXT NOT NULL, | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | |
| ); | |
| io_type TEXT NOT NULL CHECK (io_type IN ('input','output')), | |
| token TEXT NOT NULL, | |
| vault_id TEXT NOT NULL, | |
| PRIMARY KEY (transaction_hash, log_index, io_index, io_type), | |
| FOREIGN KEY (transaction_hash, log_index) REFERENCES order_events(transaction_hash, log_index) | |
| ); |
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/sql/tables.sql around lines 44 to
49, the io_type column currently allows any text; add a CHECK constraint to
restrict values to 'input' or 'output'. Modify the table definition so io_type
is declared as NOT NULL with a CHECK (io_type IN ('input','output')) (or add a
separate table-level CHECK line) to enforce allowed values; update any relevant
migration or schema version if you maintain migrations.
Comment on lines
+131
to
+156
| CREATE INDEX idx_deposits_vault ON deposits(sender, token, vault_id); | ||
| CREATE INDEX idx_deposits_block ON deposits(block_number); | ||
| CREATE INDEX idx_deposits_token ON deposits(token); | ||
|
|
||
| CREATE INDEX idx_withdrawals_vault ON withdrawals(sender, token, vault_id); | ||
| CREATE INDEX idx_withdrawals_block ON withdrawals(block_number); | ||
| CREATE INDEX idx_withdrawals_token ON withdrawals(token); | ||
|
|
||
| CREATE INDEX idx_order_events_hash ON order_events(order_hash); | ||
| CREATE INDEX idx_order_events_owner ON order_events(order_owner); | ||
| CREATE INDEX idx_order_events_block ON order_events(block_number); | ||
|
|
||
| CREATE INDEX idx_order_ios_token ON order_ios(token); | ||
|
|
||
| CREATE INDEX idx_take_orders_owner ON take_orders(order_owner); | ||
| CREATE INDEX idx_take_orders_block ON take_orders(block_number); | ||
|
|
||
| CREATE INDEX idx_clear_events_alice_bob ON clear_v3_events(alice_order_hash, bob_order_hash); | ||
| CREATE INDEX idx_clear_events_block ON clear_v3_events(block_number); | ||
| CREATE INDEX idx_clear_alice_vaults ON clear_v3_events(alice_input_vault_id, alice_output_vault_id); | ||
| CREATE INDEX idx_clear_bob_vaults ON clear_v3_events(bob_input_vault_id, bob_output_vault_id); | ||
|
|
||
| CREATE INDEX idx_after_clear_block ON after_clear_v2_events(block_number); | ||
|
|
||
| CREATE INDEX idx_meta_subject ON meta_events(subject); | ||
| CREATE INDEX idx_meta_block ON meta_events(block_number); No newline at end of file |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Optional: idempotency and ergonomics
- Consider IF NOT EXISTS on all CREATE TABLE/INDEX to ease repeated bootstrap.
- Consider indexes on frequently filtered columns (e.g., order_ios.vault_id).
🤖 Prompt for AI Agents
In crates/common/src/raindex_client/sqlite_web/sql/tables.sql around lines 131
to 156, the CREATE INDEX statements are not idempotent and are missing an index
on a frequently filtered column; update each CREATE INDEX to use "IF NOT EXISTS"
so repeated bootstraps won't error, and add a new index definition for
order_ios(vault_id) (also with IF NOT EXISTS) to cover queries filtering by that
column. Ensure naming follows existing conventions (idx_<table>_<columns>) and
place the new index near the other order_ios index for readability.
Contributor
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 123 🏁 Script executed: Length of output: 3860 SIZE=L 🧠 Learnings used |
This was referenced Oct 2, 2025
This was referenced Oct 6, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Chained PR - Do not merge before #2100
Motivation
See issue: #2071 and #2072
After fetching and decoding orderbook contract event data, we need a way to create the insert commands for the sqlite db. This PR implements that for the decoded events.
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
fix #2071
fix #2072
Summary by CodeRabbit
New Features
Chores