Update REMOTE_SETTINGS_URL to new GitHub link#2136
Conversation
WalkthroughUpdated the REMOTE_SETTINGS_URL in packages/webapp/src/routes/+layout.ts to point to a new commit of the remote settings.yaml. No other code, control flow, or exports changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed Checks (1 warning)
✅ Passed Checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)packages/webapp/**/*.{svelte,ts,js}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
packages/{webapp,ui-components}/**/*.{svelte,ts,js,css,scss}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (1)📚 Learning: 2025-05-13T10:19:19.558ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/webapp/src/routes/+layout.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
packages/webapp/**/*.{svelte,ts,js}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
packages/webapp/**/*.{svelte,ts,js}: Webapp: build withnpm run build -w @rainlanguage/webapp
Webapp: lint/format check withnpm run svelte-lint-format-check -w @rainlanguage/webapp
Webapp: run tests withnpm run test -w @rainlanguage/webapp
Files:
packages/webapp/src/routes/+layout.ts
packages/{webapp,ui-components}/**/*.{svelte,ts,js,css,scss}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Frontend changes must include a screenshot of the built webapp after
npm run build && npm run preview
Files:
packages/webapp/src/routes/+layout.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: test
- GitHub Check: standard-tests (ubuntu-latest, rainix-rs-artifacts, true)
- GitHub Check: standard-tests (ubuntu-latest, test-js-bindings)
- GitHub Check: Deploy-Docs-Preview
- GitHub Check: Deploy-Preview-Push
🔇 Additional comments (1)
packages/webapp/src/routes/+layout.ts (1)
13-14: REMOTE_SETTINGS_URL update validated
Only occurrence ofREMOTE_SETTINGS_URLin packages/webapp/src/routes/+layout.ts has been updated to the new commit hash; the URL returns HTTP 200 and valid YAML.
- Attach a screenshot of the built webapp after running
npm run build -w @rainlanguage/webapp && npm run preview -w @rainlanguage/webapp- Run lint/format and tests:
npm run svelte-lint-format-check -w @rainlanguage/webapp && npm run test -w @rainlanguage/webapp
| const REMOTE_SETTINGS_URL = | ||
| 'https://raw.githubusercontent.com/rainlanguage/rain.strategies/4a91fbafccac4e791ec3fedec0b92eff7a3d4f7e/settings.yaml'; | ||
| 'https://raw.githubusercontent.com/rainlanguage/rain.strategies/862204110de94375dfcef25efceb62a991619dda/settings.yaml'; |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Make the remote settings URL configurable via env with a pinned fallback
Pinning to a commit is good for determinism, but require-less deploys would benefit from an env override (staging/prod toggles, emergency rollbacks) without code changes.
Apply this diff within these lines:
-const REMOTE_SETTINGS_URL =
- 'https://raw.githubusercontent.com/rainlanguage/rain.strategies/862204110de94375dfcef25efceb62a991619dda/settings.yaml';
+const REMOTE_SETTINGS_URL =
+ PUBLIC_ENV.PUBLIC_REMOTE_SETTINGS_URL ??
+ 'https://raw.githubusercontent.com/rainlanguage/rain.strategies/862204110de94375dfcef25efceb62a991619dda/settings.yaml';And add this import (outside the selected lines):
import { env as PUBLIC_ENV } from '$env/dynamic/public';🤖 Prompt for AI Agents
In packages/webapp/src/routes/+layout.ts around lines 13-14, replace the
hard-coded pinned REMOTE_SETTINGS_URL with a value read from the public env
import and fallback to the current pinned URL: add the import "import { env as
PUBLIC_ENV } from '$env/dynamic/public';" (outside the edited lines) and change
the const to use PUBLIC_ENV.PUBLIC_REMOTE_SETTINGS_URL ?? '<current pinned
URL>'; this lets runtime override via PUBLIC_REMOTE_SETTINGS_URL while
preserving the pinned commit as fallback.
1 participant
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit