feat: add local-db manifest URL command#2553
Open
findolor wants to merge 1 commit intorename-orderbook-to-raindexfrom
Open
feat: add local-db manifest URL command#2553findolor wants to merge 1 commit intorename-orderbook-to-raindexfrom
findolor wants to merge 1 commit intorename-orderbook-to-raindexfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PRs
Motivation
rain.local-db.remotecurrently fetches a settings YAML file and parseslocal-db-remotesin shell to discover manifest URLs. That duplicates settings parsing logic outside Rust and can drift from the CLI/parser behavior.Solution
Add a
local-db manifest-urlsCLI command that prints local DB remote manifest URLs from settings YAML:raindex_cli local-db manifest-urls --settings-yaml "$settings_yaml"RaindexYaml, so normal settings requirements such asversionandlocal-db-remotesvalidation apply.local-db-remotesURL values in the core settings parser, so all settings consumers share the same uniqueness rule.Checks
By submitting this for review, I'm confirming I've done the following:
Verified locally:
nix develop -c cargo fmt --allnix develop -c cargo test -p raindex_app_settings local_db_remotesnix develop -c cargo test -p raindex_cli manifest_urlsnix develop -c cargo test -p raindex_cli verify_clinix develop -c rainix-rs-static