OrderBook Subgraph testing CI#36
Closed
NanezX wants to merge 172 commits into
Closed
Conversation
2023 30 09 subgraph cli
remove submodule recursive
thedavidmeister
requested changes
Nov 8, 2023
Contributor
thedavidmeister
left a comment
thedavidmeister
left a comment
There was a problem hiding this comment.
other than the specific comments, high level concerns
- The PR is far too large, it seems like this easily could have been split into smaller PRs, as it stands we have 68 thousand LOC to review in a single pass
- the rust code is generally undocumented and untested
- commented out code and typos makes the PR appear unfinished to me, probably a symptom of it being so large that you couldn't even check it properly yourself @NanezX
| @@ -0,0 +1,76 @@ | |||
| use colored::*; | |||
Contributor
There was a problem hiding this comment.
don't have undifferentiated util modules
|
|
||
| let full_cmd = format!("{} {}", main_cmd, args.join(" ")); | ||
|
|
||
| println!("{} {}\n", "Running:".green(), full_cmd.blue()); |
Contributor
There was a problem hiding this comment.
use tracing not println
| stdout_handle.join().expect("Failed to join stdout thread"); | ||
|
|
||
| if status.success() { | ||
| println!("✅ {} {}\n", full_cmd.blue(), "completed".green()); |
Contributor
There was a problem hiding this comment.
use standard tracing and standard log levels, emojis and colours could cause issues for logging/monitoring tools
| version: '3' | ||
| services: | ||
| evm_node: | ||
| image: vishalkale151071/hardhat-node |
Contributor
There was a problem hiding this comment.
private docker, use org
| - postgres | ||
| extra_hosts: | ||
| - host.docker.internal:host-gateway | ||
| environment: |
Contributor
There was a problem hiding this comment.
hardcoded environment?
| let end_point = "http://localhost:8020/"; | ||
| let subgraph_name = "test/test"; | ||
|
|
||
| let data = MapBuilder::new() |
Contributor
There was a problem hiding this comment.
why are we working with unstructured string interpolation? does serde_yaml not work?
| std::env::current_dir().unwrap().display(), | ||
| root_dir | ||
| )) | ||
| .args(&["-c", "npx graph codegen && npx graph build"]) |
|
|
||
| pub struct Query; | ||
|
|
||
| impl Query { |
|
|
||
| pub struct SyncStatus; | ||
|
|
||
| pub async fn wait() -> anyhow::Result<bool> { |
| @@ -0,0 +1,1252 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
why are generated files being committed to the repo?
Contributor
|
closing as this should be smaller PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.