test: add rust-shell closure regression test#160
Conversation
Mirror of test/bats/devshell/sol-shell/closure.test.bats. Asserts the rust-shell nix closure has no foundry/solc/slither, no node/npm, and no chromium — these are deliberately absent so consumers like rain.cli that ship a pure rust binary skip the heavy default closure. Mutation-tested locally: - pkgs.foundry in buildInputs → assertion 1 fires - pkgs.nodejs_22 in buildInputs → assertion 2 fires - writeShellScriptBin "chromium-mut-stub" → assertion 3 fires - revert → all 3 pass Wired into check-shell.yml so the regression is enforced in CI. Tracks rainix#141 (rust-shell side). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Summary
Add a closure regression test for `rust-shell` mirroring the one for `sol-shell`. Asserts the rust-shell nix closure has no foundry/solc/slither, no node/npm, and no chromium — deliberately absent so consumers like rain.cli that ship a pure rust binary skip the heavy default closure.
Adds:
Tracks #141 (rust-shell side). js-shell is the remaining half.
Mutation test
Each assertion was verified locally by injecting an offending package and confirming the matching assertion fires:
Test plan
Generated with Claude Code.