Skip to content

fix(ci): drop pkgs.chromium from default devShell#171

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-05-13-drop-chromium
May 13, 2026
Merged

fix(ci): drop pkgs.chromium from default devShell#171
thedavidmeister merged 1 commit into
mainfrom
2026-05-13-drop-chromium

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

  • Remove pkgs.chromium from the default Linux devShell. cache.nixos.org does not have a prebuilt chromium for the pinned nixpkgs revision, so Linux runners spend hours compiling from source and hit the 6h job timeout.
  • Drop the chromium.test.bats smoke test that asserted chromium was on PATH; nothing in rainix actually invokes it.
  • README + slim-shell comments updated to drop the now-stale "no chromium" enumeration.
  • The sol-shell / rust-shell closure tests continue to assert chromium is absent from those slim closures.

Closes #170.

Test plan

  • CI green on Linux without timing out
  • sol-shell closure test (asserts no chromium) still passes
  • rust-shell closure test (asserts no chromium) still passes

🤖 Generated with Claude Code

cache.nixos.org does not have a prebuilt chromium binary for the
nixpkgs revision pinned in flake.lock, so Linux runners spend hours
compiling chromium from source on every fresh Nix store cache —
exceeding the 6h job timeout under load.

The chromium wrapper was only ever used to satisfy the default-shell
chromium.test.bats smoke check; no rainix code path actually invokes
it. Drop it from the default shell and remove the test. The slim
sol-shell / rust-shell closure tests continue to assert chromium is
absent from those closures.

Closes #170.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this May 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 50 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 617ddf56-6731-4e34-a2ab-9a1245df78c3

📥 Commits

Reviewing files that changed from the base of the PR and between 49fb732 and 37c992d.

📒 Files selected for processing (3)
  • README.md
  • flake.nix
  • test/bats/devshell/default/chromium.test.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-13-drop-chromium

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit ce6df30 into main May 13, 2026
13 checks passed
@github-actions
Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ubuntu CI hangs building pkgs.chromium from source

1 participant