update nix flake and bump up rust version #84
Conversation
|
Warning Rate limit exceeded@thedavidmeister has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis change updates the Rust toolchain version in Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant CachingAction
Developer->>GitHub Actions: Push code / open PR
GitHub Actions--x CachingAction: (Step commented out, no invocation)
GitHub Actions->>Developer: Run remaining workflow steps
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
.github/workflows/check-shell.yml
Outdated
|
|
||
| - uses: DeterminateSystems/nix-installer-action@v4 | ||
| - uses: DeterminateSystems/magic-nix-cache-action@v2 | ||
| # - uses: DeterminateSystems/magic-nix-cache-action@v2 |
There was a problem hiding this comment.
This is supposed to be switched to flakehub-cache-action as magic-nix-cache-action is deprecated
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
flake.nix (1)
382-388: 🧹 Nitpick (assertive)Remove unused
tauri-librariesbinding
Thetauri-librarieslist is declared but never used in thetauri-shelldevShell. Consider removing this binding to reduce unused code and avoid confusion:- # NOTE: this binding is unused - tauri-libraries = [ - pkgs.gtk3 - pkgs.cairo - pkgs.gdk-pixbuf - pkgs.glib - pkgs.dbus - pkgs.openssl_3 - pkgs.librsvg - pkgs.gettext - pkgs.libiconv - ] ++ (pkgs.lib.optionals (!pkgs.stdenv.isDarwin) [ - # This is probably needed but is marked as broken in nixpkgs - pkgs.webkitgtk - ]);
♻️ Duplicate comments (2)
.github/workflows/test.yml (1)
34-34: Deprecated cache action is commented out
TheDeterminateSystems/magic-nix-cache-action@v2step has been disabled. If build caching is still desired, please replace it with the recommendedflakehub-cache-actionor another up-to-date caching solution as per the deprecation notice..github/workflows/check-shell.yml (1)
21-21: Deprecated cache action is commented out
TheDeterminateSystems/magic-nix-cache-action@v2step has been disabled. If caching is needed here, switch to the supportedflakehub-cache-actionor an equivalent up-to-date action.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/workflows/check-shell.yml(1 hunks).github/workflows/test.yml(1 hunks).gitmodules(0 hunks).vscode/extensions.json(1 hunks)REUSE.toml(1 hunks)flake.nix(10 hunks)
💤 Files with no reviewable changes (1)
- .gitmodules
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/check-shell.yml
[error] 9-9: wrong indentation: expected 10 but found 12
(indentation)
[error] 11-11: wrong indentation: expected 10 but found 12
(indentation)
[error] 13-13: wrong indentation: expected 10 but found 12
(indentation)
[error] 14-14: wrong indentation: expected 8 but found 10
(indentation)
🔇 Additional comments (4)
.vscode/extensions.json (1)
1-5: Add VS Code Nix IDE recommendation
Including"jnoortheen.nix-ide"will help contributors get Nix language support in VS Code and aligns well with the project’s Nix-based workflows.REUSE.toml (1)
10-11: Extend REUSE annotations to .vscode directory
Adding".vscode/**/"alongside".github/**/"ensures that compliance metadata also covers the new VS Code configuration files.flake.nix (2)
18-23: Verify Rust version bump and update flake.lock
The toolchain has been upgraded to Rust"1.87.0". Please ensure thatpkgs.rust-bin.stable."1.87.0"is available, then run:nix flake update --update-input rust-overlay(and any other updated inputs) to regenerate
flake.lock. Committing the updated lock file will prevent version drift.
361-365: Simplifypackagesexport withinherit
Usinginheritfor therainix-sol-*,rainix-rs-*, andtauri-release-envattributes reduces boilerplate and aligns with Nix best practices.
| ubuntu-latest, | ||
| # intel mac | ||
| macos-13, | ||
| # apple silicon | ||
| macos-latest, | ||
| ] |
There was a problem hiding this comment.
Fix indentation for YAML compliance
The entries in the os matrix are misaligned, causing YAMLlint errors. Align the list items under os: [ by reducing two spaces of indentation so they start directly under the bracket. For example:
matrix:
- os: [
- ubuntu-latest,
- # intel mac
- macos-13,
- # apple silicon
- macos-latest,
- ]
+ os: [
+ ubuntu-latest,
+ # intel mac
+ macos-13,
+ # apple silicon
+ macos-latest,
+ ]Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 9-9: wrong indentation: expected 10 but found 12
(indentation)
[error] 11-11: wrong indentation: expected 10 but found 12
(indentation)
[error] 13-13: wrong indentation: expected 10 but found 12
(indentation)
[error] 14-14: wrong indentation: expected 8 but found 10
(indentation)
🤖 Prompt for AI Agents
In .github/workflows/check-shell.yml around lines 9 to 14, the list items under
the os matrix are indented incorrectly, causing YAMLlint errors. Fix this by
reducing the indentation of each list item by two spaces so they align directly
under the opening bracket of the os array, ensuring proper YAML syntax and
compliance.
There was a problem hiding this comment.
this was auto-formatted and shouldn't be an issue unless humans say it is
There was a problem hiding this comment.
@0xgleb, I understand your perspective on auto-formatted code. You're right that if the YAML is functionally correct and was produced by an auto-formatter, these indentation warnings may be more pedantic than practical.
If the YAMLlint errors become problematic in your CI pipeline, you could consider:
- Configuring YAMLlint to be less strict about indentation
- Ensuring your auto-formatter and linter are aligned in their formatting preferences
- Adding a
.yamllint.ymlconfig to ignore specific indentation rules
For now, I'll note your preference about auto-formatted code for future reviews.
/| /|
( ._. )
o_(")(")
Thoughtfully notes your formatting preferences
✏️ Learnings added
Learnt from: 0xgleb
PR: rainlanguage/rainix#84
File: .github/workflows/check-shell.yml:9-14
Timestamp: 2025-05-26T18:06:48.993Z
Learning: The user 0xgleb prefers not to flag formatting issues in auto-formatted code (like YAML files) unless they cause actual functional problems or humans specifically complain about them. Auto-formatter output should generally be accepted even if it doesn't perfectly align with linting rules.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
Motivation
We need the latest version of Rust to use the latest version of Alloy
Solution
Bump up
nixpkgs(to make the latest version of Rust available) and switch to the latest version of RustChecks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit