2025 07 18 any

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

• New Features
  • Introduced a new "any" logical operation, returning the first binary non-zero input.
• Bug Fixes
  • Improved accuracy of the "any" operation to ensure correct handling of binary inputs.
• Tests
  • Added comprehensive tests for the new "any" operation, covering integrity, execution, and evaluation scenarios.
  • Removed legacy tests for the previous "any" operation implementation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The "any" opcode implementation was replaced with a new version (LibOpAny), updating all references, function pointers, and metadata accordingly. The constant for the number of standard ops was incremented. Associated tests for the old implementation were removed, and a new comprehensive test suite for the new implementation was added.

Changes

File(s)	Change Summary
src/lib/op/LibAllStandardOps.sol	Switched all references from LibOpAnyNP to LibOpAny, updated metadata, incremented ops length.
src/lib/op/logic/LibOpAny.sol	Renamed library and updated function signatures and internal logic to use StackItem types.
test/src/lib/op/logic/LibOpAny.t.sol	Added new test contract LibOpAnyTest covering integrity, execution, and evaluation of new opcode.
test/src/lib/op/logic/LibOpAnyNP.t.sol	Removed old test contract for the previous LibOpAnyNP implementation.

Sequence Diagram(s)

sequenceDiagram
    participant TestSuite as LibOpAnyTest
    participant LibOpAny as LibOpAny
    participant Interpreter as InterpreterState

    TestSuite->>LibOpAny: referenceFn(state, operand, inputs)
    LibOpAny->>LibOpAny: Loop over StackItem[] inputs
    LibOpAny-->>TestSuite: Return StackItem[] outputs

    TestSuite->>Interpreter: Evaluate "any" opcode
    Interpreter->>LibOpAny: run(state, operand, inputs)
    LibOpAny-->>Interpreter: Return first non-zero input as StackItem
    Interpreter-->>TestSuite: Return evaluation result

Loading

Possibly related PRs

• gt op #356: Refactors the "greater-than" opcode in a similar way by replacing its implementation and updating related metadata and function pointers, mirroring the approach taken for the "any" opcode in this PR.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3aa2959 and d9e9788.

⛔ Files ignored due to path filters (3)

• src/generated/Rainterpreter.pointers.sol is excluded by !**/generated/**
• src/generated/RainterpreterExpressionDeployer.pointers.sol is excluded by !**/generated/**
• src/generated/RainterpreterParser.pointers.sol is excluded by !**/generated/**

📒 Files selected for processing (4)

• src/lib/op/LibAllStandardOps.sol (6 hunks)
• src/lib/op/logic/LibOpAny.sol (2 hunks)
• test/src/lib/op/logic/LibOpAny.t.sol (1 hunks)
• test/src/lib/op/logic/LibOpAnyNP.t.sol (0 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.