fix every

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of zero values to ensure consistent and explicit representation in calculations.

• Tests

  • Added a new test to verify correct behavior when zero values with exponents are present.
  • Renamed an existing test for clarity; no change in test logic.

[coderabbitai]

Walkthrough

The changes update the handling of zero values in the LibOpEvery library to ensure explicit assignment of zero when encountered, both in the main logic and reference implementation. Additionally, a new test checks behavior with zero values having non-zero exponents, and an existing test function is renamed for clarity.

Changes

Cohort / File(s)	Change Summary
src/lib/op/logic/LibOpEvery.sol	Modified zero value handling: explicitly assigns zero in both run and referenceFn functions.
test/src/lib/op/logic/LibOpEvery.t.sol	Added test for zero values with exponents; renamed a test for clarity; no logic changes to existing tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• every #381: Introduced the LibOpEvery library and its tests, which are further refined in this PR, especially regarding zero value handling.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 096f985 and 849c024.

⛔ Files ignored due to path filters (1)

• src/generated/Rainterpreter.pointers.sol is excluded by !**/generated/**

📒 Files selected for processing (2)

• src/lib/op/logic/LibOpEvery.sol (2 hunks)
• test/src/lib/op/logic/LibOpEvery.t.sol (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: thedavidmeister
PR: rainlanguage/rain.interpreter#360
File: src/lib/op/erc20/LibOpERC20Allowance.sol:0-0
Timestamp: 2025-07-15T11:31:28.010Z
Learning: In the rainlanguage/rain.interpreter project, forge (Foundry's formatting tool) handles code formatting automatically, so formatting-related suggestions are not actionable.

Learnt from: thedavidmeister
PR: rainlanguage/rain.interpreter#360
File: src/lib/op/erc20/LibOpERC20Allowance.sol:35-36
Timestamp: 2025-07-15T11:39:30.188Z
Learning: When providing code review feedback in the rain.interpreter codebase, always check and apply existing learnings consistently. Do not suggest approaches that contradict established preferences already documented in the learnings, such as suggesting error handling with default values when the preference is to let calls fail explicitly.

Learnt from: thedavidmeister
PR: rainlanguage/rain.interpreter#360
File: src/lib/op/erc20/LibOpERC20Allowance.sol:0-0
Timestamp: 2025-07-15T11:31:35.645Z
Learning: In the rain.interpreter codebase, the team uses forge for automatic code formatting, so manual formatting suggestions are not needed as the tool will handle formatting automatically.

Learnt from: thedavidmeister
PR: rainlanguage/rain.interpreter#368
File: test/src/lib/op/math/uint256/LibOpUint256Mul.t.sol:56-69
Timestamp: 2025-07-17T14:15:14.886Z
Learning: In multiplication overflow detection tests like LibOpUint256MulTest, when performing sequential multiplication (a * b * c * d...), encountering a zero value means the final result will always be zero regardless of subsequent values. Since zero multiplied by any value (including MAX_UINT256) cannot overflow, it's safe and correct to break out of the overflow detection loop early when zero is encountered.

src/lib/op/logic/LibOpEvery.sol (3)

Learnt from: thedavidmeister
PR: #381
File: src/lib/op/logic/LibOpEvery.sol:24-46
Timestamp: 2025-07-27T22:56:57.898Z
Learning: In Rain interpreter stack operations like LibOpEvery, when the output position (stackTop) is set to coincide with an input item's position on the stack, explicit writing may not be needed if the desired output value is already at that position. The function can return the pointer to that position directly, leveraging the existing stack layout.

Learnt from: thedavidmeister
PR: #368
File: test/src/lib/op/math/uint256/LibOpUint256Mul.t.sol:56-69
Timestamp: 2025-07-17T14:15:14.886Z
Learning: In multiplication overflow detection tests like LibOpUint256MulTest, when performing sequential multiplication (a * b * c * d...), encountering a zero value means the final result will always be zero regardless of subsequent values. Since zero multiplied by any value (including MAX_UINT256) cannot overflow, it's safe and correct to break out of the overflow detection loop early when zero is encountered.

Learnt from: 0xgleb
PR: #334
File: crates/eval/src/trace.rs:92-118
Timestamp: 2025-06-17T18:01:06.316Z
Learning: User 0xgleb considers refactoring to remove a single duplicate as premature optimization in crates/eval/src/trace.rs when dealing with trace-filtering logic.

test/src/lib/op/logic/LibOpEvery.t.sol (1)

Learnt from: thedavidmeister
PR: #368
File: test/src/lib/op/math/uint256/LibOpUint256Mul.t.sol:56-69
Timestamp: 2025-07-17T14:15:14.886Z
Learning: In multiplication overflow detection tests like LibOpUint256MulTest, when performing sequential multiplication (a * b * c * d...), encountering a zero value means the final result will always be zero regardless of subsequent values. Since zero multiplied by any value (including MAX_UINT256) cannot overflow, it's safe and correct to break out of the overflow detection loop early when zero is encountered.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: rainix (ubuntu-latest, test-wasm-build)
• GitHub Check: rainix (ubuntu-latest, rainix-sol-artifacts)
• GitHub Check: rainix (ubuntu-latest, rainix-sol-static)
• GitHub Check: rainix (ubuntu-latest, rainix-rs-static)
• GitHub Check: rainix (ubuntu-latest, rainix-sol-test)
• GitHub Check: rainix (macos-latest, rainix-rs-artifacts)
• GitHub Check: rainix (macos-latest, rainix-rs-test)
• GitHub Check: rainix (ubuntu-latest, rainix-rs-artifacts)
• GitHub Check: rainix (ubuntu-latest, rainix-rs-test)
• GitHub Check: git-clean

🔇 Additional comments (4)

src/lib/op/logic/LibOpEvery.sol (2)

36-41: Good fix for consistent zero representation.

The explicit assignment of 0 instead of the original item ensures that zero values are consistently stored as integer zero, regardless of their original representation (e.g., 0e5). This aligns with the reference implementation and prevents potential issues with different zero encodings.

---

59-62: Consistent zero handling in reference implementation.

The explicit reassignment to Float.wrap(0) when a zero is detected ensures consistency between the main run() function and the reference implementation. This prevents the reference function from returning a previously processed non-zero value when a zero is encountered.

test/src/lib/op/logic/LibOpEvery.t.sol (2)

88-91: Excellent test coverage for zero representation fix.

This test directly validates the fix in LibOpEvery by ensuring that zero values with non-zero exponents (like 0e5) are properly handled and return 0 as expected. This provides good coverage for the consistency improvements made in the main library.

---

94-94: Good correction of test function name.

The rename from testOpAnyEvalFail to testOpEveryEvalFail properly aligns the test name with its actual purpose of testing the every operation failure case.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 2025-07-28-every

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.