floor

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

• New Features

  • Added support for the "floor" operation, allowing users to compute the floor of decimal numbers using floating point representation.

• Refactor

  • Updated the underlying number handling for the "floor" operation from fixed-point to floating-point decimals, improving precision and consistency.

• Tests

  • Enhanced and modernized tests for the "floor" operation to use floating-point types and updated abstractions.

[coderabbitai]

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between eb47fa0 and d9c0388.

📒 Files selected for processing (1)

• test/src/lib/op/logic/LibOpConditions.t.sol (2 hunks)

Walkthrough

The "floor" opcode has been fully integrated into the standard operations set. This includes enabling its import, updating metadata, handler, integrity, and runtime execution in the opcode registry. The implementation of "floor" is refactored to use decimal floating-point arithmetic, and all related tests are updated to use the new abstractions and types.

Changes

Cohort / File(s)	Change Summary
Standard Ops Integration src/lib/op/LibAllStandardOps.sol	Enabled the "floor" opcode by uncommenting its import and adding it to the opcode registry, metadata, operand handler, integrity, and runtime arrays. Updated the opcode count constant from 59 to 60.
Floor Opcode Refactor src/lib/op/math/LibOpFloor.sol	Refactored the "floor" opcode to use decimal floating point (Float/LibDecimalFloat) instead of fixed-point math. Updated function signatures to use OperandV2 and StackItem. Added a new referenceFn for reference testing.
Floor Opcode Tests Update test/src/lib/op/math/LibOpFloor.t.sol	Uncommented and updated tests for the "floor" opcode to use the new floating-point types and abstractions. Changed operand and input types, and updated test cases to use LibDecimalFloat.packLossless for encoding test values.

Sequence Diagram(s)

sequenceDiagram
    participant Interpreter
    participant LibAllStandardOps
    participant LibOpFloor
    participant LibDecimalFloat

    Interpreter->>LibAllStandardOps: Lookup "floor" opcode
    LibAllStandardOps->>LibOpFloor: Call integrity() and run()
    LibOpFloor->>LibDecimalFloat: Apply floor() to Float value
    LibDecimalFloat-->>LibOpFloor: Return floored Float
    LibOpFloor-->>LibAllStandardOps: Return result
    LibAllStandardOps-->>Interpreter: Return result

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

• e constant #375: Integrates the "e" opcode with similar updates to LibOpE, its tests, and registration—mirroring the approach taken for "floor" in this PR.
• linear growth #377: Integrates the "linear growth" opcode, updating its implementation and registration in a manner analogous to the changes for "floor".
• 2025 07 09 div #351: Refactors and integrates the "div" opcode with decimal floating-point arithmetic, following the same opcode enablement and refactor pattern as seen here for "floor".

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 2025-07-29-floor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.