Conversation
This commit refactors the project into a modular architecture, separating concerns into `core` and `feature` modules, each with distinct `data`, `domain`, and `presentation` layers. This modularization improves scalability, maintainability, and build times. - **feat(project)**: Introduced a multi-module architecture with `core` and `feature` modules. - **feat(build)**: Configured Gradle build scripts (`build.gradle.kts`, `settings.gradle.kts`, `gradle/libs.versions.toml`) to support the new KMP module structure. - **feat(modules)**: Added boilerplate code, including `Platform` implementations, test files, `.gitignore`, and `AndroidManifest.xml` for each new module.
Contributor
|
Important Review skippedToo many files! This PR contains 289 files, which is 139 over the limit of 150. You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This commit refactors the project into a multi-module architecture and introduces Gradle convention plugins to streamline the build process. The core logic is separated into `core` and `feature` modules, each with distinct `data`, `domain`, and `presentation` layers. This modularization improves scalability, maintainability, and build times. - **refactor(project)!**: Migrated from a monolithic `composeApp` to a multi-module architecture. Source code has been moved from `composeApp` into new `core` and `feature` modules. - **feat(build)**: Introduced Gradle convention plugins (`cmp.application`, `cmp.library`, `cmp.feature`, `kmp.library`, `room`, `buildkonfig`) to standardize module configurations. - **chore(build)**: Updated Gradle build scripts (`build.gradle.kts`, `settings.gradle.kts`, `gradle/libs.versions.toml`) to support the new modular structure and convention plugins. - **chore(tests)**: Removed placeholder and boilerplate test files (`ExampleInstrumentedTest.kt`, `ExampleUnitTest.kt`) from all modules. - **refactor(di)**: Updated Koin dependency injection modules to reflect the new module structure. - **refactor(auth)**: Moved authentication-related models (`DeviceStart`, `DeviceTokenSuccess`) to the `core:domain` and `core:data` modules and renamed them for clarity (e.g., `GithubDeviceStart`). - **refactor(network)**: Centralized `HttpClient` creation and rate-limiting logic into the `core:data` module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the project into a modular architecture, separating concerns into
coreandfeaturemodules, each with distinctdata,domain, andpresentationlayers. This modularization improves scalability, maintainability, and build times.coreandfeaturemodules.build.gradle.kts,settings.gradle.kts,gradle/libs.versions.toml) to support the new KMP module structure.Platformimplementations, test files,.gitignore, andAndroidManifest.xmlfor each new module.