SIR-1523 - Validate watched saves before upload#69
Merged
Conversation
6c4f31a to
6f305bb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f305bb. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
6f305bb to
a451eb9
Compare
xolott-ark
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
raisely startfor campaign styles and components before upload.Note
Medium Risk
Medium risk because it changes
raisely startwatcher behavior and introduces token-dependent validation before uploads, which could affect developer workflows if validation or watcher wiring is incorrect.Overview
Adds per-save validation to
raisely startwatchers: campaign stylesheet saves now callvalidateCampaignSassbeforeuploadStyles, and component saves callvalidateComponentbeforeupdateComponentFile/updateComponentConfig, failing theoraloader inline and skipping the upload on validation errors.Refactors watcher logic into exported, dependency-injectable helpers (
handleCampaignChange,handleComponentChange,registerStartWatchers) and adds Vitest coverage to ensure invalid saves don’t upload, subsequent valid saves recover, and watcher callbacks keep running after failures.Risk Assessment (Framework v2.0)
startcommand and related validation callsMitigating Factors
Findings
Outstanding findings: 0
Overall risk: MEDIUM
Decision: APPROVED
Rationale: Single Tier 1 Medium (auth-adjacent token validation before uploads) with good unit coverage and no open findings.
Reviewed by Cursor Bugbot for commit a451eb9. Bugbot is set up for automated code reviews on this repo. Configure here.