[feat] : Add skipSeconds prop to customizable skipping period#2
Open
Shariar-Hasan wants to merge 2 commits intorakib86:mainfrom
Open
[feat] : Add skipSeconds prop to customizable skipping period#2Shariar-Hasan wants to merge 2 commits intorakib86:mainfrom
skipSeconds prop to customizable skipping period#2Shariar-Hasan wants to merge 2 commits intorakib86:mainfrom
Conversation
Owner
|
It works, but the SVG icons need to be dynamic based on the skipseconds value. Currently, the SVG icons are hardcoded for the forward and backward buttons with a skipseconds value of 10 seconds. You need to update that as well. |
Author
|
should i continue on creating the icons for forward and backword skipping, or should i stop here. as the PR closed? |
Owner
|
You can continue with dynamic forward backward icon with Dynamic skip seconds value in it,then create a PR |
Author
not exactly, but is it okay if i use this as dynamic icon for forward skip.
|
Owner
|
the icons needs like the circle one as before, as player needs to be looks good. your icon dont follow the minimal theme as now. try to make a circle icon with number in it like the current one. |
Author
|
got it. i will look forward to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature of #1