MetaData Jackson serialization of Json property field name with spaces

[dilbertside]

Hi,

Problem description:
I have a singular problem related to an extjs customized vertical stacked graph, where the legend title and yField is the property name field.

I generate a dynamic graph with a reconfigurable store. At init and refresh the graph build/redraw itself with a ExtDirectMethodType.STORE_READ with a ExtDirectStoreReadResult which the result is like List<Map<String, Object>> result = Lists.newArrayList(); and a MetaData metaData and data built on the fly.
That was working wonderfully, no troubles so far.

The problem rose when users suddenly decided to change the name to a double name with space (previously it was a concise single string alpha).
Suddenly, I faced a Json parse error on extjs side because the engine cannot parse a
{...
hello world: 'guten tag'
...}
as a property field name.

So my question/request/enhancement would be to force the wrapping of the property name quoted with single quote or double quote, would it make sense and have some value for the library?

I did have a look on Jackson and there are some stuff which would be possible to do, but I don't want to do on a global basis by tweaking Jackson2ObjectMapperFactoryBean or your JsonHandler permanently.
I would rather for that unique case force the property name wrapping by quote by introduce a localized mixin eventually.

My concern is to not burden EDS library with some if then else in the serialization step for a case that so far no one has met.

For moment I will overwrite in camel case the property name which could on arrival be unwrapped (possible after a successful parsing and a hook in the store event metachange hopefully).

What do you think?

Thanks in advance,

[ralscha]

Hi

I'm a bit confused, because Jackson always wraps field names with quotes.
It is possible to explicitly disable field quoting but as a default fields
are always surrounded with quotes.

Ralph

On Fri, Apr 12, 2013 at 6:54 AM, dilbertside notifications@github.comwrote:

Hi,

Problem description:
I have a singular problem related to an extjs customized vertical stacked
graph, where the legend title and yField is the property name field.

I generate a dynamic graph with a reconfigurable store. At init and
refresh the graph build/redraw itself with a ExtDirectMethodType.STORE_READ
with a ExtDirectStoreReadResult which the result is like List> result =
Lists.newArrayList(); and a MetaData metaData and data built on the fly.
That was working wonderfully, no troubles so far.

The problem rose when users suddenly decided to change the name to a
double name with space (previously it was a concise single string alpha).
Suddenly, I faced a Json parse error on extjs side because the engine
cannot parse a
{...
hello world: 'guten tag'
...}
as a property field name.

So my question/request/enhancement would be to force the wrapping of the
property name quoted with single quote or double quote, would it make sense
and have some value for the library?

I did have a look on Jackson and there are some stuff which would be
possible to do, but I don't want to do on a global basis by tweaking
Jackson2ObjectMapperFactoryBean or your JsonHandler permanently.
I would rather for that unique case force the property name wrapping by
quote by introduce a localized mixin eventually.

My concern is to not burden EDS library with some if then else in the
serialization step for a case that so far no one has met.

For moment I will overwrite in camel case the property name which could on
arrival be unwrapped (possible after a successful parsing and a hook in the
store event metachange hopefully).

What do you think?

Thanks in advance,

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67
.

[dilbertside]

I'm sorry, I may not have explain myself clearly.
I guess the title of this thread is misleading.

example with a
List<Map<String, Object>> result = Lists.newArrayList();
Map<String, Object> map = Maps.newHashMap();
....
map.put("id", 12);
map.put("hello world", "guten tag");
...
result.add(map);
ExtDirectStoreReadResult response= new ExtDirectStoreReadResult(result.size(), result, true);

what would be serialized as Json object
{...
id: 12
hello world: 'guten tag'
...}

which is wrong in Json. what's good is
{...
id: 12
'hello world': 'guten tag'
...}

[ralscha]

But jackson always wraps field names. It's a requirement for a valid json.
That's the reason I'm confused that your field names are not surrounded
with quotes.

This is correct
{...
"id": 12
"hello world": "guten tag"
...}

On Fri, Apr 12, 2013 at 7:43 AM, dilbertside notifications@github.comwrote:

I'm sorry, I may not have explain myself clearly.
I guess the title of this thread is misleading.

example with a
List> result = Lists.newArrayList();
Map map = Maps.newHashMap();
....
map.put("id", 12);
map.put("hello world", "guten tag");
...
result.add(map);
ExtDirectStoreReadResult response= new
ExtDirectStoreReadResult(result.size(), result, true);

what would be serialized as Json object
{...
id: 12
hello world: 'guten tag'
...}

which is wrong in Json. what's good is
{...
id: 12
'hello world': 'guten tag'
...}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-16276884
.

[dilbertside]

I get Error parsing json response
with real case of what I get, after beautifying the response

[{
type: "rpc",
tid: 9,
action: "rs",
method: "lbodd",
result: {
metaData: {
root: "records",
totalProperty: "total",
successProperty: "success",
idProperty: "id",
fields: [{
name: "id",
type: "int",
text: "id"
}, {
name: "m",
type: "string",
text: "m"
}, {
name: "Overseas Movie",
type: "float",
text: "Overseas Movie"
}, {
name: "Shaw",
type: "float",
text: "Shaw"
}, {
name: "Golden Place",
type: "float",
text: "Golden Place"
}, {
name: "Eng Wah",
type: "float",
text: "Eng Wah"
}
]
},
success: true,
total: 4,
records: [{
id: 1,
Shaw: 1.0,
Golden Place: 0.0,
Eng Wah: 0.0,
m: "Nanda Kore",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}, {
id: 2,
Overseas Movie: 0.0,
Shaw: 0.58,
Golden Place: 0.0,
Eng Wah: 0.42,
m: "Fala Serio",
cc: ["Eng Wah", "Golden Place", "Overseas Movie", "Shaw"]
}, {
id: 3,
Shaw: 0.25,
Golden Place: 0.25,
Eng Wah: 0.5,
m: "Happythankyoumoreplease",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}, {
id: 4,
Shaw: 0.48,
Golden Place: 0.35,
Eng Wah: 0.17,
m: "Hello I Must Be Going",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}
]
}
}
]

[ralscha]

That is very strange. In my JSON the field names are always quoted.
Did you disable field quoting in your ObjectMapper?
Something like this:
ObjectMapper mapper = new ObjectMapper();
mapper.configure(JsonGenerator.Feature.QUOTE_FIELD_NAMES, false);

Here an example JSON from http://eds.rasc.ch/demo/extjs42/metadata.html
[{"type":"rpc","tid":1,"action":"personAction","method":"loadPersonFullName","result":{"metaData":{"root":"records","totalProperty":"total","successProperty":"success","start":0,"limit":100,"sortInfo":{"field":"fullName","direction":"DESC"},"fields":[{"name":"fullName","type":"string","header":"Full
Name","width":60,"sortable":false,"resizable":true,"hideable":false}]},"success":true,"total":5000,"records":[{"fullName":"acqueline
Logan"},{"fullName":"Zorita Rhodes"},{"fullName":"Zorita
Oneill"},{"fullName":"Zorita Brady"},{"fullName":"Zorita
Becker"},{"fullName":"Zoe Ortega"},{"fullName":"Zoe
Guerrero"},{"fullName":"Zoe Cote"},{"fullName":"Zoe
Burnett"},{"fullName":"Zia Yates"},{"fullName":"Zia Wise"},{"fullName":"Zia
Washington"},{"fullName":"Zia Roberson"},{"fullName":"Zia
Rhodes"},{"fullName":"Zia Perez"},{"fullName":"Zia
Holder"},{"fullName":"Zia Hines"},{"fullName":"Zeus
Whitehead"},{"fullName":"Zeus Caldwell"},{"fullName":"Zeus
Andrews"},{"fullName":"Zephr Mullins"},{"fullName":"Zephr
Fowler"},{"fullName":"Zephr Brady"},{"fullName":"Zephania
Singleton"},{"fullName":"Zephania Donaldson"}]}}]

On Fri, Apr 12, 2013 at 8:19 AM, dilbertside notifications@github.comwrote:

I get Error parsing json response
with real case of what I get, after beautifying the response

[{
type: "rpc",
tid: 9,
action: "rs",
method: "lbodd",
result: {
metaData: {
root: "records",
totalProperty: "total",
successProperty: "success",
idProperty: "id",
fields: [{
name: "id",
type: "int",
text: "id"
}, {
name: "m",
type: "string",
text: "m"
}, {
name: "Overseas Movie",
type: "float",
text: "Overseas Movie"
}, {
name: "Shaw",
type: "float",
text: "Shaw"
}, {
name: "Golden Place",
type: "float",
text: "Golden Place"
}, {
name: "Eng Wah",
type: "float",
text: "Eng Wah"
}
]
},
success: true,
total: 4,
records: [{
id: 1,
Shaw: 1.0,
Golden Place: 0.0,
Eng Wah: 0.0,
m: "Nanda Kore",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}, {
id: 2,
Overseas Movie: 0.0,
Shaw: 0.58,
Golden Place: 0.0,
Eng Wah: 0.42,
m: "Fala Serio",
cc: ["Eng Wah", "Golden Place", "Overseas Movie", "Shaw"]
}, {
id: 3,
Shaw: 0.25,
Golden Place: 0.25,
Eng Wah: 0.5,
m: "Happythankyoumoreplease",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}, {
id: 4,
Shaw: 0.48,
Golden Place: 0.35,
Eng Wah: 0.17,
m: "Hello I Must Be Going",
cc: ["Eng Wah", "Golden Place", "Shaw"]
}
]
}
}
]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-16277623
.

[dilbertside]

weird, isn't it? I fail to understand for moment.

no what I have is

@bean
Jackson2ObjectMapperFactoryBean objectMapper(){
Jackson2ObjectMapperFactoryBean bean = new Jackson2ObjectMapperFactoryBean();
bean.setAutoDetectFields(true);
bean.setAutoDetectGettersSetters(false);
return bean;
}

@Bean
public JsonHandler jsonHandler() {
    JsonHandler jsonHandler = new JsonHandler();
    ObjectMapper objectMapper = objectMapper().getObject();
    jsonHandler.setMapper(objectMapper);
    return jsonHandler;
}

[dilbertside]

now I commented bean Jackson2ObjectMapperFactoryBean

I get same as http://eds.rasc.ch/demo/extjs42/metadata.html

Some Spring mystery behind...

   /*@Bean
Jackson2ObjectMapperFactoryBean objectMapper(){
    Jackson2ObjectMapperFactoryBean bean = new Jackson2ObjectMapperFactoryBean();
    bean.setAutoDetectFields(true);
    bean.setAutoDetectGettersSetters(false);
    return bean;
}*/

@Bean
public JsonHandler jsonHandler() {
    JsonHandler jsonHandler = new JsonHandler();
    ObjectMapper objectMapper = new ObjectMapper();//objectMapper().getObject();
    jsonHandler.setMapper(objectMapper);
    return jsonHandler;
}

[dilbertside]

Ok it seems a problem beyond EDS library. I guess we can close the case.
I will do more research to understand how Spring mapper merged with yours goes wild.

[ralscha]

I looked into the source code of Jackson2ObjectMapperFactoryBean but can't
find anything that disables field name quoting.

Does it work when you add this line of code?
objectMapper.configure(JsonGenerator.Feature.QUOTE_FIELD_NAMES, true);

Very weird problem..

Ralph

On Fri, Apr 12, 2013 at 9:47 AM, dilbertside notifications@github.comwrote:

Ok it seems a problem beyond EDS library. I guess we can close the case.
I will do more research to understand how Spring mapper merged with yours
goes wild.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-16279968
.

[dilbertside]

even worse, the whole Extjs MVC app failed to load
with

@Bean
Jackson2ObjectMapperFactoryBean objectMapper(){
    Jackson2ObjectMapperFactoryBean bean = new Jackson2ObjectMapperFactoryBean();
    bean.setAutoDetectFields(true);
    bean.setAutoDetectGettersSetters(false);
    return bean;
}

@Bean
public JsonHandler jsonHandler() {
    JsonHandler jsonHandler = new JsonHandler();
    ObjectMapper objectMapper = objectMapper().getObject();
    objectMapper.configure(com.fasterxml.jackson.core.JsonGenerator.Feature.QUOTE_FIELD_NAMES, true);
    //objectMapper.disable(MapperFeature.USE_BIG_DECIMAL_FOR_FLOATS);
    jsonHandler.setMapper(objectMapper);
    return jsonHandler;
}