Skip to content

Initial strategy implementation#2

Merged
raman325 merged 11 commits intomainfrom
strategy
Feb 3, 2024
Merged

Initial strategy implementation#2
raman325 merged 11 commits intomainfrom
strategy

Conversation

@raman325
Copy link
Copy Markdown
Owner

@raman325 raman325 commented Feb 1, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@raman325 raman325 marked this pull request as ready for review February 3, 2024 07:43
@raman325 raman325 merged commit dfe30c5 into main Feb 3, 2024
@raman325 raman325 deleted the strategy branch February 3, 2024 07:43
jhenkens added a commit to jhenkens/lock_code_manager that referenced this pull request Oct 21, 2025
Replace async_config_entry_first_refresh() with async_request_refresh()
in async_update_listener() to prevent calling the first_refresh API after
the config entry has already transitioned to LOADED state.

**Issue:**
The async_config_entry_first_refresh() method is only meant to be called
during initial setup when the config entry is in SETUP_IN_PROGRESS state.
Calling it in async_update_listener() (after the entry is LOADED) will
become a hard error in Home Assistant 2025.11.

**Fix:**
Use async_request_refresh() instead, which is the correct API for
refreshing coordinators after initial setup is complete.

**Location:**
- custom_components/lock_code_manager/__init__.py:466

Fixes TODO raman325#2 - Breaking change deadline: HA 2025.11

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
raman325 added a commit that referenced this pull request Mar 29, 2026
- Fix #1: Add subscribing flag to prevent double-subscription race
- Fix #2: Use entry parameter instead of closure in _on_config_update
- Fix #3: Add console.warn on subscription failure instead of silent catch
- Fix #4: Add type: 'grid' to watcher section in generate-view
- Fix #5: Add lcm-config-watcher to HTMLElementTagNameMap, register in main.ts
- Fix #6: Add test for slot removal detection
- Fix #7: Use frozenset in _get_structure_snapshot for immutable snapshots

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: d5aa37bae447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant