Skip to content

Fixed docs#200

Merged
kedashoe merged 1 commit intoramda:masterfrom
Andarist:docs-fix
Oct 13, 2017
Merged

Fixed docs#200
kedashoe merged 1 commit intoramda:masterfrom
Andarist:docs-fix

Conversation

@Andarist
Copy link
Copy Markdown
Contributor

@kedashoe
Copy link
Copy Markdown
Contributor

Looks ok to me, @MattMS @buzzdecafe?

@MattMS
Copy link
Copy Markdown
Member

MattMS commented Oct 12, 2017

What is the reason for changing from targeting the single dist file to the src folder?

Also, if we target the folder, the jsdoc script break once this repo is updated to 0.25.0, since the folder seems to have been renamed from src to source.

@kedashoe
Copy link
Copy Markdown
Contributor

It is related to ramda/ramda#2328. Rollup mangles some names when building dist/ramda.js, but we have more control over what ends up in src so the names should be ok.

src is included in the npm package, so I think we should be ok there as this points to the installed package.

It does feel a off to me though. We have been building from a file in the repo and now we are building from something that is not in vc. Should we have a script copy node_modules/ramda/src to somewhere in the repo?

@Andarist
Copy link
Copy Markdown
Contributor Author

It does feel a off to me though. We have been building from a file in the repo and now we are building from something that is not in vc. Should we have a script copy node_modules/ramda/src to somewhere in the repo?

Whatever you choose, I havent found any compelling reason myself to copy it, just for sake of copying.

Let me know what would you like me to do!

@kedashoe
Copy link
Copy Markdown
Contributor

Alright I'm ok with it, can always change later if we find a reason to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants