Skip to content

Document partial build functionality#807

Merged
buzzdecafe merged 1 commit intoramda:masterfrom
benjamingr:patch-2
Feb 14, 2015
Merged

Document partial build functionality#807
buzzdecafe merged 1 commit intoramda:masterfrom
benjamingr:patch-2

Conversation

@benjamingr
Copy link
Copy Markdown
Contributor

Adds a description of how to make a partial build of Ramda, closes #806

I will create a separate PR for the docs repo as it's in a different repo. Note I've also included the /docs fix here.

@benjamingr
Copy link
Copy Markdown
Contributor Author

Hey, in first look it looks like the index file in the docs repo is generated from the README.md file here - is this the case or should I submit a separate PR for the docs repo?

README.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say that the functions in the description should match the functions in the example. So the preferable way to go is probably to remove src/curry.js and src/map.js from the example

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger. Editing.

@buzzdecafe
Copy link
Copy Markdown
Member

Hey, in first look it looks like the index file in the docs repo is generated from the README.md file here - is this the case or should I submit a separate PR for the docs repo?

no need to pr vs. ramda.github.io

@benjamingr
Copy link
Copy Markdown
Contributor Author

@buzzdecafe thanks. In that case the PR is done - you can merge it if you'd like.

Great work on the library, having something powerful like this in JS is really refreshing, as someone who's never seen the point of underscore given the native methods this has shown me a new light :) Asked that question and started this PR since we're actually deploying an internal app using Ramda. Thanks again for saving me time by making the library.

@buzzdecafe
Copy link
Copy Markdown
Member

thanks for the kind words. can you please squash to one commit? then looks good to merge

Adds a description of how to make a partial build of Ramda, closes ramda#806

Only include used functions.
@benjamingr
Copy link
Copy Markdown
Contributor Author

Done

@buzzdecafe
Copy link
Copy Markdown
Member

thanks!

buzzdecafe added a commit that referenced this pull request Feb 14, 2015
Document partial build functionality
@buzzdecafe buzzdecafe merged commit b9b5b54 into ramda:master Feb 14, 2015
@benjamingr benjamingr deleted the patch-2 branch February 14, 2015 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial builds?

2 participants