Make create_for_owner! idempotent and race-safe#2
Merged
Conversation
- Return existing wallet if one already exists for owner + asset_code - Handle race conditions with rescue for RecordNotUnique/RecordInvalid - Normalize asset_code before lookup/create - Extract initial_balance_credit_attributes for subclass overriding - Add test for idempotent behavior Gemspec cleanup: - Use git ls-files for cleaner file list - Exclude dev directories (.claude, .cursor, .github, test, etc.) - Add Rails version ceiling (< 9.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
Wallet.create_for_owner!idempotent and race-safe, and cleans up the gemspec for release.Changes
Idempotent wallet creation
RecordNotUnique/RecordInvalidinitial_balance_credit_attributesfor subclass overriding (used byusage_credits)Gemspec cleanup
git ls-filesfor cleaner file list.claude,.cursor,.github,test, etc.)< 9.0)Test plan
🤖 Generated with Claude Code