Skip to content

#18 Added paramter support for get operations (transactions) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rameezk merged 3 commits into from
Aug 28, 2025
Merged

#18 Added paramter support for get operations (transactions) #21

rameezk merged 3 commits into from
Aug 28, 2025

Conversation

@belasin
Copy link

@belasin belasin commented Aug 27, 2025

Add support for parameters into the get function and more specifically the transactions method addresses #18

  • from date
  • to date
  • transaction type

Added transaction filtering:
feb6ff8 
 - from date
 - to date
 - transaction type
@belasin belasin marked this pull request as ready for review August 27, 2025 22:02
Justin Unwin added 2 commits August 28, 2025 00:31
rameezk#17 Completed the mapping of account and balance types
7b2579c 
Additionally added the pending_transactions get operation.
Solve deprecation warning regarding using utcnow()
39d6867 
migrated to .now(timezone.utc)
@belasin
Copy link
Author

belasin commented Aug 27, 2025

Test result:

collected 7 items

tests/investec_python/test_client.py::TestInvestec::test_api_url PASSED [ 14%]
tests/investec_python/test_client.py::TestInvestec::test_account_list PASSED [ 28%]
tests/investec_python/test_client.py::TestInvestec::test_account_balance PASSED [ 42%]
tests/investec_python/test_client.py::TestInvestec::test_account_transactions PASSED [ 57%]
tests/investec_python/test_client.py::TestInvestec::test_account_transactions_date_range PASSED [ 71%]
tests/investec_python/test_client.py::TestInvestec::test_account_transactions_transaction_type PASSED [ 85%]
tests/investec_python/test_client.py::TestInvestec::test_pending_transactions PASSED [100%]

========================================================= 7 passed in 13.85s =========================================================

rameezk
rameezk approved these changes Aug 28, 2025
View reviewed changes
Copy link
Owner

@rameezk rameezk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for your contribution! :)

@rameezk rameezk merged commit cc7cf45 into rameezk:main Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rameezk rameezk rameezk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@belasin @rameezk