Open
Conversation
Introduce escalation support for monitors and incidents across client and server. - Client: add EscalationSettings component, integrate escalation fields into CreateMonitor form, update monitor types and validation, and i18n strings. - Server: extend Monitor and Incident models/types with escalation fields, add migration to populate defaults, expose PATCH /monitors/:monitorId/escalation, and add request validation. - Business logic: implement EscalationService to detect and trigger escalations, wire it into the SuperSimpleQueue (scheduled check every 5 mins), and reset escalation state when incidents resolve. - Repositories/controllers: add active incident query, repository mapping for new fields, and controller handler to validate and persist escalation settings. Notes: notifications sending is stubbed in the service (marked as TODO); migration adds default values for existing documents. Unit/integration tests may be needed for the new flow.
-There was a bug with the saving of escalation settings. -It was handled...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Please remove this line only before submitting your PR. Ensure that all relevant items are checked before submission.)
Describe your changes
Added an escalation feature to allow for email notifications when escalation happens
Write your issue number after "Fixes "
Fixes #123
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.