Show latest bounty in activity contributor summaries#303
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR extends the activity feature to surface latest bounty information for contributors. The API response now includes the bounty repository, issue number, and issue URL alongside existing contributor metadata. The activity template displays this information as a "Latest bounty" field in the contributor ledger card, with test assertions validating both the API shape and rendered output. ChangesLatest Bounty Contributor Metadata
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
weilixiong
left a comment
There was a problem hiding this comment.
✅ Reviewed with evidence:
Files inspected:
app/main.py: Addedlatest_bounty_repo,latest_bounty_issue_number,latest_bounty_issue_urlto contributor summariesapp/templates/activity.html: Rendered "Latest bounty" link in contributor cardtests/test_activity.py: Updated existing test assertions + template check
Changes: +12/-0 across 3 files
Verification:
pytest tests/test_activity.py -q
3 passed in 1.59s
Assessment: Clean, focused PR matching #298 bounty spec (contributor activity + bounty discovery). No scope drift. Test coverage validates both API shape and HTML template.
Risk: LOW — read-only UI enhancement, no write paths.
weilixiong
left a comment
There was a problem hiding this comment.
Review — PR #303: Show latest bounty in activity contributor summaries
Files inspected: app/main.py, app/templates/activity.html, tests/test_activity.py
What changed: Adds latest_bounty_repo, latest_bounty_issue_number, latest_bounty_issue_url to the paid-activity contributor summary, and renders a "Latest bounty" link in the activity template.
Verification:
- py_compile: all clean
- ruff check: all passed
- pytest tests/test_activity.py -x: 3/3 passed (1.05s)
- 3 files, 12 insertions, 0 deletions — focused scope
- Tests cover new field in API response and template rendering
- Activity template correctly links latest bounty issue URL
Findings: No issues. Small, well-tested feature addition. Template uses safe_public_url() consistently with existing patterns. Tests verify both empty-state and populated-state rendering.
Rating: Recommended for accept.
Claim: MRWK bounty #293 (review open MergeWork PRs, round 8, 40 MRWK).
Bounty #298
Summary
/api/v1/activity.Latest bountylink in each contributor card on/activity, so readers can jump from a contributor summary to the source GitHub bounty issue behind that contributor's latest accepted work.Contributor Discovery Impact
The activity page already groups accepted work by contributor, but the contributor cards only exposed the latest accepted work and proof. This adds the missing source-bounty context to the grouped view, so contributors and maintainers can understand which bounty the contributor most recently completed without scanning the full recent-work list.
Validation
PYTHONPATH=. .venv/bin/pytest tests/test_activity.py -q-> 3 passedPYTHONPATH=. .venv/bin/pytest -q-> 243 passed, 2 existing warnings.venv/bin/ruff check app/main.py tests/test_activity.py-> passed.venv/bin/ruff format --check app/main.py tests/test_activity.py-> passedPYTHONPATH=. .venv/bin/mypy app-> successPYTHONPATH=. .venv/bin/python scripts/docs_smoke.py-> docs smoke okPYTHONPATH=. .venv/bin/python scripts/check_agents.py-> AGENTS.md okgit diff --check-> cleanNo secrets, wallet material, deployment credentials, private vulnerability details, payout details, or MRWK price claims are included.
Summary by CodeRabbit