Skip to content

Add terminal multi-award API status regression#39

Merged
ramimbo merged 1 commit into
ramimbo:mainfrom
RoyZhao1991:codex/terminal-api-status-36
May 23, 2026
Merged

Add terminal multi-award API status regression#39
ramimbo merged 1 commit into
ramimbo:mainfrom
RoyZhao1991:codex/terminal-api-status-36

Conversation

@RoyZhao1991
Copy link
Copy Markdown
Contributor

Bounty #36

Summary

  • add a focused API regression test for terminal multi-award bounty visibility
  • drive one multi-award bounty to paid and another to partial payout followed by closed
  • assert both remain visible in list/detail bounty APIs with awards_remaining equal to 0
  • assert terminal bounties are excluded from /api/v1/status active bounty count

Validation

  • uv run pytest tests/test_api_mcp.py::test_bounty_api_keeps_terminal_multi_awards_visible_but_inactive -> 1 passed
  • uv run pytest -> 73 passed
  • uv run ruff format --check . -> 28 files already formatted
  • uv run ruff check . -> All checks passed
  • uv run mypy app -> Success: no issues found in 10 source files

@newmattock
Copy link
Copy Markdown
Contributor

Review for Bounty #19: no blockers found.

I inspected tests/test_api_mcp.py around the existing paid/closed multi-award detail tests and the new combined visibility/status test. The new case covers both terminal multi-award paths still appearing in list/detail responses with awards_remaining == 0, while /api/v1/status excludes terminal bounties from the active count. This complements the existing detail-only assertions and stays within the requested test scope for #36.

Evidence checked:

  • PR diff: one file, tests/test_api_mcp.py, 71 insertions.
  • PYTHONPATH=. ../mergework-bounty-20/.venv/bin/python -m pytest tests/test_api_mcp.py::test_bounty_api_keeps_terminal_multi_awards_visible_but_inactive -q -> 1 passed.
  • PYTHONPATH=. ../mergework-bounty-20/.venv/bin/python -m pytest tests/test_api_mcp.py::test_bounty_api_reports_paid_multi_award_as_exhausted tests/test_api_mcp.py::test_bounty_api_reports_closed_multi_award_as_unavailable tests/test_api_mcp.py::test_bounty_api_keeps_terminal_multi_awards_visible_but_inactive -q -> 3 passed.
  • PYTHONPATH=. ../mergework-bounty-20/.venv/bin/python -m ruff format --check . -> 28 files already formatted.
  • PYTHONPATH=. ../mergework-bounty-20/.venv/bin/python -m ruff check . -> All checks passed.
  • PR CI test passed.

@ramimbo ramimbo merged commit d1637e0 into ramimbo:main May 23, 2026
1 check passed
@ramimbo ramimbo added the mrwk:paid Ledger payment recorded label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mrwk:paid Ledger payment recorded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants