docs(ledger): Clarify current MRWK transfer paths#397
Conversation
Document the current ledger-native transfer paths and make the bridge and off-ramp boundary explicit in public docs. Add smoke coverage so README and ledger docs keep the boundary text. Refs ramimbo#395 Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR updates public documentation to clarify that MRWK is native to the MergeWork ledger and the authoritative source for balances and transfers. It enumerates currently supported transfer paths (GitHub balance claims, wallet payouts, wallet-to-wallet transfers) while deferring future public/bridge/exchange routes. A validation script enforces that required phrases are maintained in the documented content. ChangesTransfer Paths Documentation and Validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ayskobtw-lil
left a comment
There was a problem hiding this comment.
No blockers from my review on current head df7b54a.
Evidence checked:
- Inspected
README.md,docs/ledger.md,docs/agent-guide.md, andscripts/docs_smoke.pyagainst Bounty #395. - Verified the docs clearly state MRWK is native to the MergeWork ledger and currently supports
github:*balance claims, linkedmrwk1wallet payouts, and signed wallet-to-wallet transfers between registered wallets. - Verified the docs explicitly avoid BTC, USDC, fiat, bridge, exchange, off-ramp, liquidity, price, or cash-out promises, and include the required separate maintainer/contributor discussion boundary before future bridge/onchain implementation.
- Checked that the new docs-smoke coverage pins the key public README/ledger wording so the no-off-ramp and current-transfer-path framing does not silently regress.
- Compared the overlapping PR #396 at review time; this PR covers the same core prose plus smoke coverage for the required public wording, which makes it the stronger candidate if only one #395 award can be accepted.
- Hosted
Quality, readiness, docs, and image checksis green.
Local validation:
python scripts/docs_smoke.py-> docs smoke okpython -m pytest tests/test_docs_public_urls.py -q-> 17 passedpython -m ruff check scripts/docs_smoke.py-> passedpython -m ruff format --check scripts/docs_smoke.py-> 1 file already formattedpython -m mypy scripts/docs_smoke.py-> successgit diff --check origin/main...HEAD-> clean
tolga-tom-nook
left a comment
There was a problem hiding this comment.
Reviewed PR #397 at head df7b54a8 for Bounty #395 scope.
Evidence checked:
- Inspected
README.md,docs/ledger.md,docs/agent-guide.md, andscripts/docs_smoke.pyagainst the bounty requirement. - Verified the docs explicitly cover current paths:
github:*balance claims, linkedmrwk1payouts, and signed wallet-to-wallet transfers. - Verified the docs clearly say MergeWork does not currently operate a public BTC, USDC, fiat, bridge, exchange, or off-ramp.
- Verified the future-snapshot wording is conditional and does not promise a timeline, peg, listing, bridge, off-ramp, or cash-out path.
- Ran
python3 scripts/docs_smoke.pyfrom this PR branch; result:docs smoke ok. - Attempted
./.venv/bin/python -m pytest tests/test_docs_smoke.py -q; local environment has no pytest installed in.venv, so I treated the script smoke result as the available docs validation.
Verdict: no blockers from my review. This is a focused docs-only change and the added smoke assertions are aligned with the acceptance language.
isaaclins
left a comment
There was a problem hiding this comment.
Review (evidence-backed)
Scope: Docs-only clarification of MRWK transfer paths — no runtime code.
Files inspected: README.md, docs/ledger.md, docs/agent-guide.md (from PR diff).
Findings:
- Correctly sets expectations: ledger-native MRWK, no public fiat/BTC bridge today.
- Cross-links
docs/ledger.md#current-transfer-pathsfrom README and agent guide — reduces duplicate questions. - Wording is consistent ("source of truth" vs earlier "designed for future bridges").
Suggestions (non-blocking):
- Consider a one-line changelog entry in
docs/ledger.mdhistory section if you track doc-breaking clarifications. docs/agent-guide.mdlink uses relativeledger.md— works fromdocs/; verify MCP docs site generator if you publish elsewhere.
CI: N/A (markdown only).
Verdict: Approve — accurate, contributor-friendly clarification.
Summary: Clarifies MRWK current transfer support in the ledger docs and README.
This keeps public docs clear that MRWK currently lives on the MergeWork ledger: GitHub balance claims, linked
mrwk1payouts, and signed transfers between registered wallets are supported today, while public BTC, USDC, fiat, bridge, exchange, or off-ramp support is not currently operated by MergeWork. It also points agents to the ledger docs before describing payout behavior.The docs smoke script now checks that the README and ledger docs retain the current-transfer-path language and the maintainer/contributor discussion boundary.
Bounty #395
Evidence:
./.venv/bin/python scripts/docs_smoke.py->docs smoke ok./.venv/bin/python -m ruff format --check .->65 files already formatted./.venv/bin/python -m ruff check .->All checks passed!./.venv/bin/python -m pytest tests/test_docs_public_urls.py -q->17 passed./.venv/bin/python -m pytest -q->377 passedSummary by CodeRabbit