Show capacity reduction counters on bounty list#895
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds two capacity-related summary metrics to the bounties list view and updates corresponding page tests. The template now displays counts for reduced-capacity and effectively-unavailable bounties, and the tests validate those displays using regex patterns instead of exact string matching. ChangesCapacity availability summary display
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
xiefuzheng713-alt
left a comment
There was a problem hiding this comment.
Approved current head 95e63c611623c42855d3d418df8dd3759d3c9764.
Evidence checked:
- inspected
app/templates/bounties.htmland confirmed the new cards only render existingbounty_list_summary()fields:reduced_capacity_bountiesandeffectively_unavailable_bounties; - inspected
tests/test_bounty_pages.pyand confirmed the pending-payout case asserts reduced capacity without effective unavailability, while the pending-close case asserts both reduced capacity and effective unavailability; - confirmed no backend, serializer, ledger, wallet, treasury, payout, admin-token, private-data, exchange, bridge, cash-out, or MRWK price behavior changed;
- checked hosted Quality/readiness/docs/image and CodeRabbit are both successful, and the PR is mergeStateStatus CLEAN.
Validation run locally on the current head:
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q-> 18 passed, 1 existing Starlette/httpx warninguv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py-> passeduv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py-> 1 file already formatteduv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean tree30db722f4359dbe5a4ed5c53c61d205b6448a61f- merge-tree against PR #894's current head also clean:
63ec130818e69bfac37cf71570f6984134eb89db
Verdict: the change is a focused public bounty clarity improvement and I did not find a blocker.
mauricemohr88-debug
left a comment
There was a problem hiding this comment.
Current-head review for #838 on 95e63c611623c42855d3d418df8dd3759d3c9764.
Evidence checked:
- Inspected
app/templates/bounties.html; the bounty list summary now surfaces existingsummary.reduced_capacity_bountiesandsummary.effectively_unavailable_bountiescounters without changing bounty data, capacity computation, treasury state, or payout behavior. - Inspected
tests/test_bounty_pages.py; the added assertions cover both pending payout and pending close paths, including the reduced-capacity and effectively-unavailable counter values. - Confirmed GitHub reports PR #895 open, current head
95e63c611623c42855d3d418df8dd3759d3c9764, merge state clean, and both visible checks successful. - Ran
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q: 18 passed, 1 existing Starlette warning. - Ran
uv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py: passed. - Ran
uv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py: 1 file already formatted. - Ran
uv run --python 3.12 --extra dev python scripts/docs_smoke.py: docs smoke ok. - Ran
git diff --check origin/main...HEADandgit merge-tree --write-tree origin/main HEAD: clean.
No blocker found. The change is narrow, public-safe, and makes existing effective-capacity signals visible on the public bounty list.
stmr
left a comment
There was a problem hiding this comment.
Reviewed current head 95e63c611623c42855d3d418df8dd3759d3c9764.
Checks I ran:
.venv/bin/python -m ruff check tests/test_bounty_pages.py- pass.venv/bin/python -m ruff format --check tests/test_bounty_pages.py- pass.venv/bin/python scripts/docs_smoke.py- passgit diff --check origin/main...HEAD- passgit merge-tree --write-tree origin/main HEAD- clean merge tree produced
I attempted pytest tests/test_bounty_pages.py -q, but it stayed silent in my sandbox and did not finish in a useful time window, so I am not counting pytest as passing here.
Diff review notes:
- The template only displays
summary.reduced_capacity_bountiesandsummary.effectively_unavailable_bounties, both of which are already returned bybounty_list_summary()and covered by existing API/page context shapes. - The added assertions cover both partial-capacity pending payout state and effectively unavailable pending close state, which are the two user-facing cases the new counters are meant to clarify.
- No bounty lifecycle, ledger, wallet, treasury, payout, admin, exchange, bridge, cash-out, private data, or MRWK price behavior changes are present in this diff.
No blocker found in the reviewed diff.
Summary
Bounty
Refs #845
Validation
Scope
No ledger, wallet, treasury execution, payout execution, admin-token, exchange, bridge, cash-out, MRWK price, private data, credentials, or secrets behavior changed.
Summary by CodeRabbit