feat(share): Add surge.sh artifact deployment and --share flag to deliver-artifact.py#17
Draft
ramsani wants to merge 3 commits into
Draft
feat(share): Add surge.sh artifact deployment and --share flag to deliver-artifact.py#17ramsani wants to merge 3 commits into
ramsani wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(share): Add surge.sh artifact deployment
What
Implements the Share & Deploy mechanism from Issue #12.
Adds two new files and modifies one existing file:
scripts/deploy-share.py (new): Standalone deployment tool using surge.sh
--jsonflag:{url, artifact, deployed_at, expires_at}~/.claude/html-explainer/deploy-log.jsonscripts/deliver-artifact.py (modified): Adds
--shareand--share-url-outputflags--share: callsdeploy-share.pyafter artifact approval, logsshare_urlin metadata JSON--share-url-output <path>: writes the deployed URL to a filetests/test_share_deploy.py (new): Validates the feature
test_deploy_share_help(): verifies--helpworkstest_deliver_artifact_share_flag_exists(): verifies--shareand--share-url-outputin helptest_deploy_share_json_flag(): tests JSON output (accepts graceful failure in CI)Why
The html-explainer workflow previously terminated at the local file system. Every artifact lived at
~/.claude/html-explainer/outputs/and was invisible to stakeholders without CLI access.The deploy mechanism closes this gap:
Stakeholders (PMs, designers, clients) can now self-serve artifact access via a generated URL, with no additional user friction.
Acceptance Criteria (from #12)
python scripts/deploy-share.py <artifact.html>returns a valid public URL (or graceful JSON error)--shareflag ondeliver-artifact.pytriggers publish and logs URL in metadatadeploy-log.json) tracks all published artifacts with timestamp and URLTesting
Closes #12