Merged
Conversation
Directory is used by PHPStorm.
Allow consumers of this package to rely on version of PSR-7
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Owner
|
Thank you! |
ramsey
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR adds
psr/http-messageversion 2 as an acceptable dependency.Motivation and context
See #8. Initially I thought that this could be a breaking change for your package. But it seems that it isn't, so this should be safe enough to release.
How has this been tested?
I ran all tests manually / locally via PHPUnit - all passed. Please see "additional information".
Types of changes
PR checklist
Additional Information
ramsey/devtoolsgave me an issue:\Ramsey\Dev\Tools\Composer\Command\BaseCommand::getApplicationis not compatible with\Symfony\Component\Console\Command\Command::getApplicationIt prevented me from running tests, analysis, ...etc., as described in your Contribution Guidelines. I think that you need to take a closer look at that...