Merged
Conversation
Comment out access links CLI command, API method, and tests. Mark FR-5 as disabled in RPD and cross-reference in PLAN/DEVELOP docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR disables the access links feature for the v0.1 read-only release by commenting out the associated code rather than deleting it, making it easy to re-enable in future versions. The approach mirrors the pattern already used for deposit write commands, maintaining consistency across the codebase.
Changes:
- Comment out access links CLI commands, API methods, and tests using block comments with explanatory headers
- Update documentation files to mark FR-5 (Access Links) and related references as disabled for v0.1
- Leave model structs uncommented (consistent with existing pattern for disabled features)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/cli/access.go | Wraps entire CLI command structure in block comment with v0.1 explanation |
| internal/api/access.go | Comments out ListAccessLinks API method with explanatory header |
| internal/api/access_test.go | Disables TestListAccessLinks test |
| .claude/reference/v0.1/RPD.md | Strikes through FR-5 requirements and marks as disabled |
| .claude/reference/v0.1/PLAN.md | Annotates access.go references as disabled for v0.1 |
| .claude/reference/v0.1/DEVELOP.md | Updates file structure documentation to note disabled status |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
access links listCLI command,ListAccessLinksAPI method, and associated testELI5
The access links feature lets you list secret share links on Zenodo records. Since v0.1 is a read-only release and this command isn't needed yet, we're hiding it — same as we did with the deposit write commands. The code is still there (just commented out) so we can turn it back on later.
Test plan
go build ./...passesgo test ./...passeszenodo.exeno longer showsaccessin help output🤖 Generated with Claude Code