Issue 63 - Fix entry reslice edge case (no containing function) + tests & reports#70
Merged
ran-j merged 1 commit intoran-j:mainfrom Feb 20, 2026
Merged
Conversation
Owner
|
Nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ran-j already introduced the main fix in commit 4334e74 (“fixed entry slicing logic to avoid same tail repeated”).
While validating on SLUS‑202.67, there was still one duplicated end address. Turns out that this is an edge case where an entry does not have a resolvable containing function.
What changed
Tests
Note
For local runtime testing had to add
<cmath>inps2_runtime_macros.hto resolvesqrtf/copysignf/INFINITY, but it has been removed before this PR.