Skip to content

fixing saving HTML file#164

Merged
ranaroussi merged 1 commit intoranaroussi:mainfrom
yarimiz:main
Feb 14, 2022
Merged

fixing saving HTML file#164
ranaroussi merged 1 commit intoranaroussi:mainfrom
yarimiz:main

Conversation

@yarimiz
Copy link
Copy Markdown
Contributor

@yarimiz yarimiz commented Feb 14, 2022

This PR is to fix an issue where the open used for saving the HTML report is using the output variable instead of download_filename

@yarimiz yarimiz mentioned this pull request Feb 14, 2022
@ranaroussi ranaroussi merged commit 6726753 into ranaroussi:main Feb 14, 2022
@yarimiz
Copy link
Copy Markdown
Contributor Author

yarimiz commented Feb 14, 2022

Thanks @ranaroussi
I think you can close issue #126

@syntaxsdev
Copy link
Copy Markdown

I think there is some additional missed for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants