fix issue 489#490
Closed
none2003 wants to merge 1 commit intoranaroussi:mainfrom
Closed
Conversation
none2003
commented
Nov 29, 2025
none2003
commented
- Remove redundant DataFrame conversion for returns data
- Add isinstance check to ensure proper handling of DataFrame inputs
- Improve figure size calculation logic for multi-column returns
- Maintain compatibility with both Series and DataFrame return types
- Remove redundant DataFrame conversion for returns data - Add isinstance check to ensure proper handling of DataFrame inputs - Improve figure size calculation logic for multi-column returns - Maintain compatibility with both Series and DataFrame return types
Owner
|
Thank you for your contribution! This issue has been addressed in PR #494 (2026 Modernization) which includes a comprehensive fix for the underwater plot to show the average drawdown line in both `reports.full` and `reports.html`. Once PR #494 is merged, this PR can be closed. We appreciate you taking the time to identify and work on this fix! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.