Skip to content

Conversation

@aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 31, 2024

Summary

Fixes #10043

Occurred changes and/or fixed issues

  • Update logic of hasError in provisioning.cattle.io.cluster model
  • Add unit test for cluster.status.conditions which affect the outcome of hasError model property

Technical notes summary

Areas or cases that should be tested

NOTE: I never tested it this way, so I am not 100% this will work. All of the investigation was based on the HAR files output and code checks in Dashboard which I've tried to sum up in the comments of #10043

Areas which could experience regressions

Screenshot/Video

@aalves08 aalves08 added this to the v2.9.0 milestone Jan 31, 2024
@aalves08 aalves08 self-assigned this Jan 31, 2024
@aalves08 aalves08 marked this pull request as ready for review January 31, 2024 17:58
@aalves08 aalves08 requested review from nwmac and richard-cox January 31, 2024 18:00
@aalves08
Copy link
Member Author

@richard-cox me and @nwmac chose this course of action in a sync we had earlier in the day. @nwmac I think that I've captured the correct logic of what we discussed in the code change

@aalves08 aalves08 requested a review from nwmac February 1, 2024 09:49
@aalves08 aalves08 force-pushed the 10043-eks-cluster-not-clickable-ui branch from 5e0f829 to 4164071 Compare February 1, 2024 11:27
@aalves08 aalves08 merged commit 21327c5 into rancher:master Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

One EKS cluster not clickable in the UI

2 participants