Miscellaneous content tweaks for k3s#1031#1990
Merged
davidnuzik merged 9 commits intorancher:masterfrom Nov 12, 2019
davidnuzik:random-changes
Merged
Miscellaneous content tweaks for k3s#1031#1990davidnuzik merged 9 commits intorancher:masterfrom davidnuzik:random-changes
davidnuzik merged 9 commits intorancher:masterfrom
davidnuzik:random-changes
Conversation
- This makes changes to the quick-start and install guides that change wording around HA. - Prevoiusly we only suggested HA for ALL production enviornments this is no longer the case. Single-server is okay if some down time is tolerable. - This commit includes a couple of misc tweaks to fix wording in related areas.
added 6 commits
November 11, 2019 16:00
- This changes the quick-start guide so we just remove the K3S_CLUSTER_SECRET environemnt variable. It wasn't needed for a simple quick-start. - I changed the ha install guide so that we mention the K3S_CLUSTER_SECRET / --cluster-secret in this area as it would be likely relevant here i.e. for auto-scaling node pools.
- node-requirements "set" env var, not "pass" - single-server remove duplicate "specific" word - possibly some other minor tweaks
- We plan to eventually remove support for hyperkube so we will no longer document here.
- Addresses 2 comments about the HA page: k3s-io/k3s#1031 (comment) k3s-io/k3s#1031 (comment)
- Only support what we have tested 10.7 and 11.5 and remove the "R1"
- Fixes the direction of arrows in the iamge - Addresses k3s-io/k3s#1031 (comment)
davidnuzik
changed the title
32 tasks
catherineluse
suggested changes
Nov 12, 2019
- Resolve all four comments posted by Catherine.
davidnuzik
commented
Nov 12, 2019
Contributor
Author
davidnuzik
left a comment
davidnuzik
left a comment
There was a problem hiding this comment.
Addessed concerns and fixed in new commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About:
Miscellaneous content tweaks. For k3s-io/k3s#1031 (Does not address all concerns. That issue is intended as guidance for @davidnuzik to make changes in this PR; that k3s issue may or may not be closed after this PR is merged in)
Commit Summaries:
Adjust quick-start and install pages regarding downtimeTweak quick-start and the install guides to have more friendly wording around single-server production setups. We mention that single-server is okay if some down time can be tolerated.
Modify quick-start to remove cluster-secret and add to ha install guideJust remove K3S_CLUSTER_SECRET from the quick-start page it's not needed there for a simple quick-start. Move it instead to the HA install guide where it would highly likely be utilized such as for user-data for an auto-scaling node pool.
Resolve nitpicks / wordage in a couple of areasSome very minor changes that were random nitpicks in [Documentation] A bunch of random little changes for docs k3s-io/k3s#1031
Remove hyperkubeWe plan to eventually remove hyperkube support so we have planned to start by removing documentation for it.
Change Installation Options title to InstallationSimply changes the name of the page from "Installation Options" to just "Installation"
Addresses this comment [Documentation] A bunch of random little changes for docs k3s-io/k3s#1031 (comment)
HA fixes for comments in GH issueAddresses to comments left in the GH issue by tweaking the wordage used for 2 load balancers.
[Documentation] A bunch of random little changes for docs k3s-io/k3s#1031 (comment)
[Documentation] A bunch of random little changes for docs k3s-io/k3s#1031 (comment)
Update HA Recommended Architecture image - fix arrowsAddresses one comment left in GH issue by tweaking the HA image arrows direction
[Documentation] A bunch of random little changes for docs k3s-io/k3s#1031 (comment)