Traefik: Update to match current behavior for custom configs#2583
Merged
davidnuzik merged 1 commit intorancher:masterfrom Aug 31, 2020
joakimr-axis:joakimr-axis_traefik-conf
Merged
Traefik: Update to match current behavior for custom configs#2583davidnuzik merged 1 commit intorancher:masterfrom joakimr-axis:joakimr-axis_traefik-conf
davidnuzik merged 1 commit intorancher:masterfrom
joakimr-axis:joakimr-axis_traefik-conf
Conversation
catherineluse
added
[zube]: Inbox
Waiting for QA/verification
[zube]: In Review
and removed
[zube]: Inbox
labels
| The Traefik ingress controller will use ports 80, 443, and 8080 on the host (i.e. these will not be usable for HostPort or NodePort). | ||
|
|
||
| Traefik can be configured by editing the `traefik.yaml` file. For more information, refer to the official [Traefik for Helm Configuration Parameters.](https://github.com/helm/charts/tree/master/stable/traefik#configuration) | ||
| Traefik can be configured by editing the `traefik.yaml` file. Then you must deploy k3s with the `--no-deploy traefik` option to prevent k3s from using (and overwriting your modified version with) the default traefik.yaml and store your modified copy in the k3s/server/manifests directory. For more information, refer to the official [Traefik for Helm Configuration Parameters.](https://github.com/helm/charts/tree/master/stable/traefik#configuration) |
There was a problem hiding this comment.
Suggesting a rephrase here.
To prevent k3s from using or overwriting the modified version, deploy k3s with --no-deploy traefik and store the modified copy in the k3s/server/manifests directory.
Contributor
Author
There was a problem hiding this comment.
Excellent suggestion, I will update immediately. Thanks!
Changes in traefik.yaml will be overwritten. See @kamilgregorczyk's comment: k3s-io/k3s#1254 (comment) Change-Id: I759df77721dcba0d170086660396e7be32ff57cf Signed-off-by: Joakim Roubert <joakimr@axis.com>
davidnuzik
approved these changes
Aug 31, 2020
Contributor
|
Thanks for the contribution @joakimr-axis |
catherineluse
pushed a commit
that referenced
this pull request
Sep 9, 2020
In content/k3s/latest/en/networking/_index.md, `k3s/server/manifests directory` should be `k3s/server/manifests` directory. Change-Id: Icd0434cf0e833951db09e9287d4c56ff89bf5ced Signed-off-by: Joakim Roubert <joakimr@axis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in traefik.yaml will be overwritten. See @kamilgregorczyk's
comment:
k3s-io/k3s#1254 (comment)
Signed-off-by: Joakim Roubert joakimr@axis.com