when RollingUpdate deployment stategy, fleet fails to update Git Repo state back to Active

[jmatis]

https://github.com/jmatis/fleet-testing/tree/main/metrics-generator

is a simple fleet repository that works nicely as is but when I change deployment strategy to RollingUpdate
fleet git repo never comes back from Modified to Active

as far as I can tell everything gets executed correctly, it's just the "message" about it never comes back so git repo stays marked as "Modified"

logs from fleet agent after manually hitting "Force Update"
fleet-agent.log

[ron1]

Have you tried adding a diff.comparePatches to fleet.yaml for your Deployment as is done here: #189. I suspect a /spec/strategy removal operation may resolve the issue.

[jmatis]

Thank you.
adding:

diff:
  comparePatches:
  - apiVersion: apps/v1
    kind: Deployment
    name: php-nginx-deployment
    namespace: default2
    operations:
    - {"op": "remove", "path": "/spec/strategy" }

did help. Now I do have to add namespace: key and it does not inherit namespace from values.yaml (so i can't use something like namespace: {{ .Values.namespace }} )

also, is there some more deep documentation I'm missing ? I did not find any mention of diff on https://fleet.rancher.io/

[ron1]

You can combine kustomize with helm for last mile patching like a namespace key. See fleet example https://github.com/rancher/fleet-examples/tree/master/multi-cluster/helm-kustomize.

You might want to like outstanding issue #251 to add diff.comparePatches documentation.

You might also like outstanding issue #199 which would eliminate the need for diff.comparePatches for common types like this one.

I suggest you close this issue if your remaining issues are already covered.

[jmatis]

thank you for advice