Make sure GoReleaser provides fleet-helm charts checksums too#4975
Merged
Make sure GoReleaser provides fleet-helm charts checksums too#4975
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release pipeline so Fleet Helm chart packages are generated during the GoReleaser run and included in the generated checksum manifest (so they’re covered by whatever checksum/signing flow consumes that manifest).
Changes:
- Add a GoReleaser
checksum.extra_filesglob for packaged chart.tgzfiles. - Package Helm charts via a new
.github/scripts/package-charts.shinvoked from GoReleaserbefore.hooks. - Adjust the release workflow to consume chart packages from
.charts/and ignore.charts/in git.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.goreleaser.yaml |
Adds checksum inclusion for .charts/*.tgz and runs chart packaging as a pre-hook. |
.gitignore |
Ignores the generated .charts/ directory. |
.github/workflows/release.yml |
Removes the explicit “upload charts to release” step and extracts charts from .charts/ when updating the charts branch. |
.github/scripts/package-charts.sh |
New script to rewrite chart image tags and package charts into .charts/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thardeck
force-pushed
the
improve_helm_chart_packaging
branch
from
a120c85 to
deb9851
Compare
thardeck
force-pushed
the
improve_helm_chart_packaging
branch
from
deb9851 to
9671538
Compare
sbulage
approved these changes
Apr 15, 2026
weyfonk
approved these changes
Apr 16, 2026
thardeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current example checksum file without the fix.