[v0.13] Require helmRepoURLRegex for Helm credential forwarding#5139
Merged
Conversation
keep only GitGetter and FileGetter alongside the custom HTTP getter.
Helm repository credentials are no longer forwarded by default. They are only sent when the repository URL matches the pattern set in helmRepoURLRegex. Credentials are stripped when no regex matches; transport settings (CA bundle, InsecureSkipVerify) are preserved. A pre-upgrade migration Job is included to populate the field on existing GitRepos.
weyfonk
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricts go-getter to Git and file protocols, and requires
helmRepoURLRegexto be set for Helm repository credentials to be forwarded. A pre-upgrade migration Job populates the field on existing GitRepos automatically on upgrade.