Add tests for namespace label sync#5202
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds test coverage around namespace label synchronization, especially ensuring pod-security labels are filtered from bundle options while existing namespace pod-security labels are preserved.
Changes:
- Adds table coverage for
addLabelsFromOptionspod-security label filtering. - Adds an end-to-end namespace sync test preserving existing pod-security labels.
- Adds a namespace sync table case for an already-matching namespace state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds coverage for the pod-security label filtering introduced by the namespace label sync fix: - TestAddLabelsFromOptions_PodSecurityLabelsFiltered: pod-security labels from NamespaceLabels options are never applied to the namespace while existing pod-security labels on the namespace are preserved. - TestSetNamespaceLabelsAndAnnotations_PodSecurityLabelsPreserved: end-to-end check through setNamespaceLabelsAndAnnotations confirming pod-security labels on the namespace survive a sync.
thardeck
force-pushed
the
retain_relevant_labels_tests
branch
from
4c24273 to
b85753e
Compare
This was referenced May 28, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pod-security label filtering tests and a table case verifying no-op behaviour when the namespace already reflects the desired state.
TestAddLabelsFromOptions_PodSecurityLabelsFiltered: covers the rule thatpod-security.kubernetes.io/*labels fromNamespaceLabelsoptions are never applied to the namespace, while existing pod-security labels on the namespace are preserved.TestSetNamespaceLabelsAndAnnotations_PodSecurityLabelsPreserved: end-to-end check throughsetNamespaceLabelsAndAnnotationsconfirming pod-security labels on the namespace survive a sync.