fix: populate NumCPUs and MemoryMB in createFromLibraryName's StorageDRS spec

[Copilot]

Issue: rancher/rancher#47145

vSphere 8 added strict validation to the RecommendDatastores API, rejecting StoragePlacementSpec.ConfigSpec with NumCPUs = 0. This breaks content library-based VM deployment (RKE2 provisioning path) when a datastore cluster (Storage DRS) is configured.

• Fix createFromLibraryName() to pass NumCPUs and MemoryMB in the VirtualMachineConfigSpec passed to getDatastore()
• Consolidate into a single spec variable (moved up before getDatastore()) reused for both datastore selection and VM reconfiguration

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[snasovich]

Changes look sane provided the fix is tested on actual vSphere environment
Not that my approval counts since I'm the one who kicked off Copilot agent to open this PR

[HarrisonWAffel]

I tested these changes out locally and they work as expected when using the Rancher UI.

@copilot, on line 392 we're defining a VirtualMachineConfigSpec variable already. Lets just move that up in the function and also use it when finding the datastore cluster, so that we only have one config to manage.

[Copilot]

I tested these changes out locally and they work as expected when using the Rancher UI.

@copilot, on line 392 we're defining a VirtualMachineConfigSpec variable already. Lets just move that up in...

Done in 2bb5f83. Moved the spec variable up before getDatastore() and reused it for both the datastore selection and the subsequent vm.Reconfigure() call, so there's only one config to manage.

[jiaqiluo]

LGTM