bump k8s v1.36#369
Merged
Merged
Conversation
Abhishek-Valaboju
force-pushed
the
bump-k8v1.36
branch
2 times, most recently
from
433c7e1 to
571d4ed
Compare
15 tasks
There was a problem hiding this comment.
Pull request overview
Adds Kubernetes v1.36 support by updating the project’s Go toolchain/build image and bumping Kubernetes-related (and other transitive) Go module dependencies to compatible versions.
Changes:
- Bump Go version/toolchain to 1.26 (Docker build ARG +
go.moddirectives). - Update Kubernetes modules to
k8s.io/* v0.36.0and refresh related dependency graph (go.mod/go.sum). - Fix a few logging callsites to use the correct formatted logging APIs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package/Dockerfile | Bumps container build Go version to 1.26. |
| go.mod | Updates Go directive/toolchain and bumps key deps (notably k8s v0.36.0, wrangler). |
| go.sum | Refreshes dependency checksums for the updated module set. |
| drivers/vmwarefusion/fusion_darwin.go | Adjusts debug log formatting in SSH command execution path. |
| drivers/azure/azureutil/powerstate.go | Fixes warning log to use formatted logger for %q. |
| drivers/azure/azureutil/azureutil.go | Tweaks subnet error warning log message/arguments. |
Comments suppressed due to low confidence (1)
drivers/vmwarefusion/fusion_darwin.go:813
- Same logging pattern here: Debugf("%s", "..."+err.Error()) is an awkward use of Debugf and still does string concatenation. Prefer a real format string (with %v) or use Debug with separate arguments so the error is rendered consistently and without extra string building.
if err := session.Run(command); err != nil {
log.Debugf("%s", "Failed to run: " + err.Error())
return err
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
801
to
804
| session, err := client.NewSession() | ||
| if err != nil { | ||
| log.Debugf("Failed to create session: " + err.Error()) | ||
| log.Debugf("%s", "Failed to create session: " + err.Error()) | ||
| return err |
| exists, err := checkResourceExistsFromError(err) | ||
| if err != nil { | ||
| log.Warn("Unexpected get subnet operation error %v: ", err) | ||
| log.Warn("Unexpected get subnet operation error: ", err) |
snasovich
reviewed
May 13, 2026
Abhishek-Valaboju
force-pushed
the
bump-k8v1.36
branch
2 times, most recently
from
292c8df to
ece73c8
Compare
bump k8s v1.36 bump k8s v1.36 bump k8s v1.36
Abhishek-Valaboju
force-pushed
the
bump-k8v1.36
branch
from
ece73c8 to
1f6b328
Compare
Comment on lines
88
to
+92
| return Deallocated | ||
| case "deallocating": | ||
| return Deallocating | ||
| default: | ||
| log.Warn("Encountered unknown PowerState for virtual machine: %q", code) | ||
| log.Warnf("Encountered unknown PowerState for virtual machine: %q", code) |
snasovich
approved these changes
May 18, 2026
jiaqiluo
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rancher/rancher#54303
add support for kubernetes v1.36