Enable NSGs shared between multiple machines#77
Conversation
|
A point of consideration for pooled NSGs in this commit: In the pooled NSG case, we currently create one network interface per NSG and attach the network interface to the NSG referenced by the driver flag. As a result, when we have x nodes spun up in our node pool, there are x network interfaces (all part of the same subnet) that are attached to the single network security group. An alternative to this design would be to have the one NSG attached directly to the subnet, as suggested in rancher/rancher#17181 and rancher/rancher#11674. However, I chose not to include that design due to the following two edge cases:
Would love to hear if there are any opposing opinions / suggested improvements for this design! |
4982a68 to
2c82443
Compare
|
This PR should resolve the following issues: |
2c82443 to
9b8a945
Compare
559965e to
c889076
Compare
c889076 to
628ea6c
Compare
628ea6c to
976ae4a
Compare
6cb4e78 to
aad464d
Compare
|
PR has been simplified based on clarified requirements from #77 (comment) and is ready for re-review! Double checked that the expected use cases provision correctly:
|
This commit allows users of the Azure driver to submit an NSG name or ARM resource identifier to be used by multiple machines that are provisioned via Rancher Machine. If a user does not submit an NSG name, machine will default to the legacy option of creating an NSG per machine.
aad464d to
bfde51e
Compare
This PR allows users of the Azure driver to submit an NSG name or ARM resource identifier to be used by multiple machines that are provisioned via Rancher Machine. If a user does not submit an NSG name, machine will default to the legacy option of creating an NSG per machine.
Related Issues: rancher/rancher#25342, rancher/rancher#11674, rancher/rancher#17181, rancher/rancher#22147, rancher/rancher#24449