Add onRemove and fix examples for rancher-nfs #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLParse
reviewed
Jul 21, 2017
| services: | ||
| foo: | ||
| image: alpine | ||
| stdin_open: true |
Contributor
|
LGTM |
| * **NFS Version**: The NFS version to use, current used version is 4. | ||
| * **Mount Option**: Comma delimited list of default mount options, for example: 'proto=udp'. Do not specify `nfsvers` option, it will be ignored. | ||
| * **Mount Options**: Comma delimited list of default mount options, for example: 'proto=udp'. Do not specify `nfsvers` option, it will be ignored. | ||
| * **On Remove**: On removal of Rancher NFS volume, should the underlying data be retained or purged. Default is `purge`. |
There was a problem hiding this comment.
Can we add in what are the 2 options we support? purge and retain? Also, can you note that it's only as of Rancher v1.6.6+ (that's where the NFS version will be made available).
| * **Export** - (`export`): When the volume is configured with the host and export, no subfolder is created; the root export directory is mounted. | ||
| * **Export Base** - (`exportBase`): By default, the volume can be configured with the host and export base, which creates a uniquely named subfolder on the NFS server. | ||
| * **Mount Options** - (`mntOptions`): Comma delimited list of default mount options. | ||
| * **On Remove** - (`onRemove`): On removal of Rancher NFS volume, should the underlying data be retained or purged. |
There was a problem hiding this comment.
same comment as what the options and what version it's introduced into.
Contributor
Author
|
Ok, please check @deniseschannon |
Contributor
Author
|
@LLParse Please double check, added some more examples on |
Contributor
|
The new examples look good. IMO we should not even provide an example for |
Contributor
Author
|
Ok, removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.