Skip to content

Bumping version 0.28.6 to 0.29.3 for k8s dependencies.#206

Merged
ericpromislow merged 1 commit into
rancher:masterfrom
ericpromislow:45350-support-k8s-1.29
May 8, 2024
Merged

Bumping version 0.28.6 to 0.29.3 for k8s dependencies.#206
ericpromislow merged 1 commit into
rancher:masterfrom
ericpromislow:45350-support-k8s-1.29

Conversation

@ericpromislow
Copy link
Copy Markdown
Contributor

Related to issue: 45350

@ericpromislow ericpromislow requested a review from a team as a code owner May 2, 2024 22:44
Comment thread go.mod Outdated
Comment on lines +35 to +38
k8s.io/api v0.30.0
k8s.io/apiextensions-apiserver v0.29.4
k8s.io/apimachinery v0.30.0
k8s.io/apiserver v0.29.4
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k8s.io/api v0.30.0
k8s.io/apiextensions-apiserver v0.29.4
k8s.io/apimachinery v0.30.0
k8s.io/apiserver v0.29.4
k8s.io/api v0.29.3
k8s.io/apiextensions-apiserver v0.29.3
k8s.io/apimachinery v0.29.3
k8s.io/apiserver v0.29.3

@ericpromislow
Copy link
Copy Markdown
Contributor Author

+1 on getting rid of the 0.30 parts -- go mod tidy made that happen, and I should have fixed it. But the latest tag now is v0.29.4. Is there a reason we should go with 0.29.3 instead?

@MbolotSuse
Copy link
Copy Markdown
Contributor

@ericpromislow rancher's client-go fork doesn't produce updates for every k8s version. We try to stick to what our fork uses to make sure we don't introduce odd compatibility issues.

@ericpromislow ericpromislow force-pushed the 45350-support-k8s-1.29 branch from 617ba7d to 0066726 Compare May 3, 2024 18:47
@ericpromislow ericpromislow requested a review from tomleb May 3, 2024 18:47
@ericpromislow ericpromislow changed the title Mostly bumping version 0.28.6 go 0.29.4 for k8s dependencies. Bumping version 0.28.6 to 0.29.3 for k8s dependencies. May 3, 2024
Copy link
Copy Markdown
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we're going to have to update norman, apiserver and dynamiclistener here to their version that supports k8s 1.29. So it might be best to start with these first.

Here's a graph of dependencies:
image

@ericpromislow ericpromislow merged commit 2c4b19e into rancher:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants