sql: bugfix: return total resource count correctly#236
Merged
Conversation
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Signed-off-by: Silvio Moioli <silvio@moioli.net>
This was referenced Jul 5, 2024
Contributor
Author
|
JFYI @richard-cox @brudnak |
MbolotSuse
reviewed
Jul 5, 2024
Contributor
MbolotSuse
left a comment
MbolotSuse
left a comment
There was a problem hiding this comment.
LGTM pending the lasso changes to complete the work.
tomleb
approved these changes
Jul 5, 2024
Contributor
tomleb
left a comment
tomleb
left a comment
There was a problem hiding this comment.
LGTM, just gotta make sure to update lasso first
MbolotSuse
approved these changes
Jul 5, 2024
rak-phillip
pushed a commit
to rancher-sandbox/rancher-desktop-steve
that referenced
this pull request
Aug 14, 2025
* sql: drop dead code Signed-off-by: Silvio Moioli <silvio@moioli.net> * sql: bugfix: return total resource count correctly Signed-off-by: Silvio Moioli <silvio@moioli.net> * adapt tests Signed-off-by: Silvio Moioli <silvio@moioli.net> * adapt mocks Signed-off-by: Silvio Moioli <silvio@moioli.net> * TEMP: remove this when bumping lasso to include rancher/lasso#84 Signed-off-by: Silvio Moioli <silvio@moioli.net> * Use latest lasso instead of fork --------- Signed-off-by: Silvio Moioli <silvio@moioli.net> Co-authored-by: Tom Lebreux <tom.lebreux@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when browsing to a paginated list, pagination controls do not appear at the bottom of the page:
Root cause: Steve is returning the total resource count incorrectly (returning the number of returned resources, usually one page size or less, instead of the total count).
Solution: leverage new data returned by lasso with rancher/lasso#83 to return the right number.
Note this PR should be merged together with rancher/lasso#83 or functionality will break.
Result: pagination controls appear and work as expected:
FWIW I have also run the integration tests and they are all green rancher/rancher#46015
Best reviewed commit-by-commit.
Please note this contains commits from #235, disregard the first commit.
Please note this PR should be merged after https://github.com/rancher/lasso/84, and the last TEMP commit should be replaced with a lasso bump. The TEMP commit is there to show that tests pass once both changes are merged.