Add tests for concurrent AccessControl store usage#286
Merged
Conversation
tomleb
reviewed
Oct 3, 2024
Contributor
tomleb
left a comment
tomleb
left a comment
There was a problem hiding this comment.
The early nil check is a nice change, makes it easier to follow!
Mostly question about the purpose of this test / PR as I wasn't sure I understood completely.
Contributor
|
Merging as asked by @aruiz14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#47318
This PR does not change the behavior of the code, just a small refactor to make it more testable and an intentionally failing test (later disabled) to prove the problem.